change logging during upgrade (#5474)

* reduce ERROR logging on ignored exception

* string concat formatting

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Author: 3 people

engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
                                 conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
                             alter_iso_pstmt.executeUpdate();
                         }catch (SQLException e) {
-                            s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+                            s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
+                            if (s_logger.isTraceEnabled()) {
+                                s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+                            }
                             //implies iso_id1 is not present, so do nothing.
                         }
                     }catch (SQLException e) {
-                        s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+                        s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
+                        if (s_logger.isTraceEnabled()) {
+                            s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+                        }
                         //implies iso_id1 is not present, so do nothing.
                     }
                 }
             }catch (SQLException e) {
-                s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+                s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
+                if (s_logger.isTraceEnabled()) {
+                    s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+                }
                 //implies iso_id1 is not present, so do nothing.
             }
         } catch (SQLException e) {
+          s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
+          if (s_logger.isTraceEnabled()) {
+              s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+          }
             //implies iso_id1 is not present, so do nothing.
         }
     }