Commit 4f3375a
committed
fix(nas-backup): don't persist unconfirmed bitmap; gate sanity_checks
Two more Copilot review items on PR #13074:
* persistChainMetadata: only store nas.bitmap_name when the agent
confirms it via BITMAP_CREATED=. Previously fell back to
decision.bitmapNew if the agent didn't emit it, which could anchor
the next incremental on a bitmap that doesn't exist (stopped-VM
pre-seed failure was the trigger Copilot flagged, but the same risk
applies any time the marker is lost). Leaving it empty correctly
forces the next backup to a fresh full instead.
* nasbackup.sh: sanity_checks (QEMU >= 4.2 / libvirt >= 7.2) is only
needed for the incremental backup-begin path. Gate it to
`OP=backup && -n MODE` so legacy full-only callers and delete /
stats / rebase operations still work on older host versions.1 parent 3e2e144 commit 4f3375a
2 files changed
Lines changed: 15 additions & 7 deletions
File tree
- plugins/backup/nas/src/main/java/org/apache/cloudstack/backup
- scripts/vm/hypervisor/kvm
Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
444 | 447 | | |
445 | 448 | | |
446 | 449 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
607 | 607 | | |
608 | 608 | | |
609 | 609 | | |
610 | | - | |
611 | | - | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
612 | 617 | | |
613 | 618 | | |
614 | 619 | | |
| |||
0 commit comments