Merge branch 'Issues3122' into '4.20.0.0-scclouds'

Correção no estado da VM ao criar um _backup_ com o host `Down` ou `Disconnected`

Closes #3122

See merge request scclouds/scclouds!1314

Author: Fabrício Duarte

plugins/backup/knib/src/main/java/org/apache/cloudstack/backup/KnibBackupProvider.java

@@ -31,6 +31,7 @@
 import com.cloud.exception.InvalidParameterValueException;
 import com.cloud.exception.OperationTimedoutException;
 import com.cloud.host.HostVO;
+import com.cloud.host.Status;
 import com.cloud.host.dao.HostDao;
 import com.cloud.hypervisor.Hypervisor;
 import com.cloud.resource.ResourceState;
@@ -126,6 +127,7 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
+import java.util.concurrent.ExecutionException;
 import java.util.stream.Collectors;
 
 import static org.apache.cloudstack.backup.dao.BackupDetailDao.CURRENT;
@@ -311,7 +313,7 @@ public boolean takeBackup(VirtualMachine vm, boolean quiesceVm, Long backupSched
 
         try {
             outcome.get();
-        } catch (InterruptedException | java.util.concurrent.ExecutionException e) {
+        } catch (InterruptedException | ExecutionException e) {
             throw new CloudRuntimeException(String.format("Unable to retrieve result from job takeBackup due to [%s]. VM [%s].", e.getMessage(), vm.getUuid()), e);
         }
 
@@ -331,6 +333,16 @@ public Boolean orchestrateTakeBackup(Backup backup, boolean quiesceVm) {
         BackupVO backupVO = (BackupVO) backup;
         long vmId = backup.getVmId();
         VirtualMachine userVm = virtualMachineManager.findById(vmId);
+        Long hostId = vmSnapshotHelper.pickRunningHost(vmId);
+        HostVO hostVO = hostDao.findById(hostId);
+
+        if (hostVO.getStatus() == Status.Down || hostVO.getStatus() == Status.Disconnected) {
+            backupVO.setStatus(Backup.Status.Failed);
+            backupDao.update(backupVO.getId(), backupVO);
+
+            logger.error("No available host found to create backup [{}] of VM [{}]. Setting the backup as Failed.", backupVO.getUuid(), userVm.getUuid());
+            return false;
+        }
 
         validateVmState(userVm, "take backup");
         List<VolumeObjectTO> volumeTOs;
@@ -346,7 +358,6 @@ public Boolean orchestrateTakeBackup(Backup backup, boolean quiesceVm) {
 
         logger.info("Starting VM backup process for VM [{}].", userVm.getUuid());
 
-        Long hostId = vmSnapshotHelper.pickRunningHost(vmId);
         BackupOfferingVO backupOfferingVO = backupOfferingDao.findByIdIncludingRemoved(backup.getBackupOfferingId());
         NativeBackupOfferingVO nativeBackupOfferingVO = nativeBackupOfferingDao.findByUuidIncludingRemoved(backupOfferingVO.getExternalId());
 
@@ -412,7 +423,7 @@ public boolean deleteBackup(Backup backup, boolean forced) {
 
         try {
             outcome.get();
-        } catch (InterruptedException | java.util.concurrent.ExecutionException e) {
+        } catch (InterruptedException | ExecutionException e) {
             throw new CloudRuntimeException(String.format("Unable to retrieve result from job deleteBackup due to [%s]. Backup [%s].", e.getMessage(), backup.getUuid()), e);
         }
 
@@ -509,7 +520,7 @@ public boolean restoreVMFromBackup(VirtualMachine vm, Backup backup, boolean qui
 
         try {
             outcome.get();
-        } catch (InterruptedException | java.util.concurrent.ExecutionException e) {
+        } catch (InterruptedException | ExecutionException e) {
             throw new CloudRuntimeException(String.format("Unable to retrieve result from job restoreVMFromBackup due to [%s]. Backup [%s].", e.getMessage(), backup.getUuid()), e);
         }
 
@@ -602,7 +613,7 @@ public Pair<Boolean, String> restoreBackedUpVolume(Backup backup, String volumeU
 
         try {
             outcome.get();
-        } catch (InterruptedException | java.util.concurrent.ExecutionException e) {
+        } catch (InterruptedException | ExecutionException e) {
             throw new CloudRuntimeException(String.format("Unable to retrieve result from job restoreBackedUpVolume due to [%s]. Backup [%s].", e.getMessage(), backup.getUuid()), e);
         }
 
@@ -833,7 +844,6 @@ private boolean finalizeQuickRestore(VirtualMachine vm, List<VolumeInfo> volumes
         return consolidateVolumes(vm, hostId, volumesToConsolidate);
     }
 
-
     private List<VolumeInfo> getVolumesToConsolidate(VirtualMachine vm, List<NativeBackupDataStoreVO> deltasOnSecondary, List<VolumeObjectTO> volumeObjectTOS, long hostId) {
         List<VolumeInfo> volumesToConsolidate = new ArrayList<>();
 
@@ -1001,7 +1011,7 @@ private HostVO getHostToRestore(VirtualMachine vm, boolean quickRestore, Long ho
                 throw new AgentUnavailableException(String.format("No host found to quick restore VM [%s]. Please check the logs.", vm.getUuid()), -1);
             }
             host = hostDao.findByIdIncludingRemoved(hostId);
-            if (host.getStatus() != com.cloud.host.Status.Up || host.isInMaintenanceStates() || host.getResourceState() != ResourceState.Enabled) {
+            if (host.getStatus() != Status.Up || host.isInMaintenanceStates() || host.getResourceState() != ResourceState.Enabled) {
                 logger.error("Cannot quick restore if the VM's last host is in maintenance, not Up, or disabled. You may try to start it in an available host and stop it before quick" +
                         " restoring. Otherwise, use the normal restore.");
                 throw new AgentUnavailableException(String.format("No host found to quick restore VM [%s]. Please check the logs.", vm.getUuid()), -1);

plugins/backup/knib/src/test/java/org/apache/cloudstack/backup/KnibBackupProviderTest.java

@@ -17,13 +17,17 @@
 
 package org.apache.cloudstack.backup;
 
+import com.cloud.host.HostVO;
+import com.cloud.host.Status;
+import com.cloud.host.dao.HostDao;
 import com.cloud.hypervisor.Hypervisor;
 import com.cloud.storage.VolumeApiServiceImpl;
 import com.cloud.storage.VolumeVO;
 import com.cloud.storage.dao.VolumeDao;
 import com.cloud.utils.DateUtil;
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.VirtualMachineManager;
 import com.cloud.vm.snapshot.VMSnapshot;
 import com.cloud.vm.snapshot.VMSnapshotDetailsVO;
 import com.cloud.vm.snapshot.VMSnapshotVO;
@@ -142,6 +146,15 @@ public class KnibBackupProviderTest {
     @Mock
     private VolumeObjectTO volumeObjectToMock;
 
+    @Mock
+    private VirtualMachineManager virtualMachineManagerMock;
+
+    @Mock
+    private HostDao hostDaoMock;
+
+    @Mock
+    private HostVO hostVOMock;
+
     @Spy
     @InjectMocks
     private KnibBackupProvider knibBackupProviderSpy;
@@ -567,4 +580,28 @@ public void createDeltaReferencesTestFullBackupNotEndOfChainDoesNotHaveVmSnapsho
 
         verify(nativeBackupDataStoreDaoMock, Mockito.times(1)).persist(Mockito.any());
     }
+
+    @Test
+    public void orchestrateTakeBackupTestHostIsDownReturnFalse() {
+
+        Mockito.when(virtualMachineManagerMock.findById(Mockito.anyLong())).thenReturn(virtualMachineMock);
+        Mockito.when(vmSnapshotHelperMock.pickRunningHost(Mockito.anyLong())).thenReturn(1L);
+        Mockito.when(hostDaoMock.findById(Mockito.anyLong())).thenReturn(hostVOMock);
+        Mockito.when(hostVOMock.getStatus()).thenReturn(Status.Down);
+
+        boolean result = knibBackupProviderSpy.orchestrateTakeBackup(backupVoMock, false);
+        assertFalse(result);
+    }
+
+    @Test
+    public void orchestrateTakeBackupTestHostIsDisconnectedReturnFalse() {
+
+        Mockito.when(virtualMachineManagerMock.findById(Mockito.anyLong())).thenReturn(virtualMachineMock);
+        Mockito.when(vmSnapshotHelperMock.pickRunningHost(Mockito.anyLong())).thenReturn(1L);
+        Mockito.when(hostDaoMock.findById(Mockito.anyLong())).thenReturn(hostVOMock);
+        Mockito.when(hostVOMock.getStatus()).thenReturn(Status.Disconnected);
+
+        boolean result = knibBackupProviderSpy.orchestrateTakeBackup(backupVoMock, false);
+        assertFalse(result);
+    }
 }