Merge branch 'avoid-migration-while-compressing-backup' into '4.20.0.0-scclouds'

Bloquear migração de dados caso haja backups em processo de compressão

See merge request scclouds/scclouds!1332

Author: Fabrício Duarte

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java

@@ -103,7 +103,6 @@ public class DataMigrationUtility {
      */
     public boolean filesReadyToMigrate(List<TemplateDataStoreVO> templates, List<SnapshotDataStoreVO> snapshots, List<VolumeDataStoreVO> volumes, List<NativeBackupJoinVO> backups) {
         State[] validStates = {State.Ready, State.Allocated, State.Destroying, State.Destroyed, State.Failed, State.Hidden};
-        List<Backup.Status> validBackupStates = List.of(Backup.Status.BackedUp, Backup.Status.Allocated, Backup.Status.Error, Backup.Status.Failed, Backup.Status.Expunged, Backup.Status.Removed, Backup.Status.Queued);
         boolean isReady = true;
         for (TemplateDataStoreVO template : templates) {
             isReady &= (Arrays.asList(validStates).contains(template.getState()));
@@ -117,11 +116,39 @@ public boolean filesReadyToMigrate(List<TemplateDataStoreVO> templates, List<Sna
             isReady &= (Arrays.asList(validStates).contains(volume.getState()));
             logger.trace("volume state: {}", volume.getState());
         }
+        isReady &= checkIfBackupsMigrationIsPossible(backups);
+        return isReady;
+    }
+
+    private boolean checkIfBackupsMigrationIsPossible(List<NativeBackupJoinVO> backups) {
+        List<Backup.Status> invalidBackupStates = Arrays.asList(Backup.Status.BackingUp, Backup.Status.Restoring);
+        List<Backup.CompressionStatus> invalidBackupCompressionStatus = Arrays.asList(Backup.CompressionStatus.Compressing, Backup.CompressionStatus.FinalizingCompression);
+
+        List<List<BackupObject>> backupChains;
+        Set<Long> backupIdsAlreadyInChain = new HashSet<>();
+
         for (NativeBackupJoinVO backup : backups) {
-            isReady &= validBackupStates.contains(backup.getStatus());
-            logger.trace("Backup [{}] of VM [{}] has the status [{}].", backup.getUuid(), backup.getVmId(), backup.getStatus());
+            if (backup.getStatus() == Backup.Status.BackedUp && !backupIdsAlreadyInChain.contains(backup.getId())) {
+                backupChains = createBackupChain(backup);
+                backupChains.forEach(list -> backupIdsAlreadyInChain.add(list.stream().map(BackupObject::getId).findFirst().get()));
+
+                for (List<BackupObject> backupVolumeChain : backupChains) {
+                    BackupObject backupObject = backupVolumeChain.get(0);
+
+                    if (invalidBackupStates.contains(backupObject.getStatus())) {
+                        logger.debug("Migration is not possible because backup {} is in {} state.", backupObject.getUuid(), backupObject.getStatus());
+                        return false;
+                    }
+
+                    if (invalidBackupCompressionStatus.contains(backupObject.getCompressionStatus())) {
+                        logger.debug("Migration is not possible because backup {} is currently being compressed. Current compression status: {}.", backupObject.getUuid(), backupObject.getCompressionStatus());
+                        return false;
+                    }
+                }
+            }
         }
-        return isReady;
+
+        return true;
     }
 
     private boolean filesReadyToMigrate(Long srcDataStoreId) {

engine/schema/src/main/java/org/apache/cloudstack/backup/NativeBackupJoinVO.java

@@ -73,6 +73,10 @@ public class NativeBackupJoinVO {
     @Column(name = "status")
     private Backup.Status status;
 
+    @Enumerated(value = EnumType.STRING)
+    @Column(name = "compression_status")
+    private Backup.CompressionStatus compressionStatus;
+
     @Column(name = "end_of_chain")
     private Boolean endOfChain;
 
@@ -175,6 +179,10 @@ public Boolean getIsolated() {
         return BooleanUtils.isTrue(isolated);
     }
 
+    public Backup.CompressionStatus getCompressionStatus() {
+        return compressionStatus;
+    }
+
     @Override
     public String toString() {
         return ReflectionToStringBuilder.toString(this, ToStringStyle.JSON_STYLE);

engine/schema/src/main/resources/META-INF/db/views/cloud.native_backup_view.sql

@@ -26,6 +26,7 @@ SELECT  b.id,
         b.type,
         b.date,
         b.status,
+        b.compression_status,
         b.backup_offering_id,
         b.size,
         b.protected_size,

engine/storage/src/main/java/org/apache/cloudstack/storage/backup/BackupObject.java

@@ -25,6 +25,7 @@
 import com.cloud.hypervisor.Hypervisor;
 import com.cloud.storage.DataStoreRole;
 import com.cloud.utils.component.ComponentContext;
+import org.apache.cloudstack.backup.Backup;
 import org.apache.cloudstack.backup.NativeBackupJoinVO;
 import org.apache.cloudstack.backup.dao.NativeBackupJoinDao;
 import org.apache.cloudstack.engine.subsystem.api.storage.DataObject;
@@ -49,6 +50,8 @@ public class BackupObject implements DataObject {
     private long physicalSize;
     private DataStore dataStore;
     private String imageStorePath;
+    private Backup.Status status;
+    private Backup.CompressionStatus compressionStatus;
 
     @Inject
     NativeBackupJoinDao nativeBackupJoinDao;
@@ -72,6 +75,8 @@ private void configure(NativeBackupJoinVO nativeBackupJoin) {
         this.size = nativeBackupJoin.getProtectedSize();
         this.physicalSize = nativeBackupJoin.getSize();
         this.imageStorePath = nativeBackupJoin.getImageStorePath();
+        this.status = nativeBackupJoin.getStatus();
+        this.compressionStatus = nativeBackupJoin.getCompressionStatus();
         this.dataStore = storeManager.getDataStore(nativeBackupJoin.getImageStoreId(), DataStoreRole.Image);
     }
 
@@ -182,4 +187,12 @@ public Long getZoneId() {
     public String toString() {
         return uuid;
     }
+
+    public Backup.CompressionStatus getCompressionStatus() {
+        return compressionStatus;
+    }
+
+    public Backup.Status getStatus() {
+        return status;
+    }
 }