NE: apply Vishesh's suggestion

weizhouapache · weizhouapache · commit 82777514c4ee · 2026-05-26T16:45:04.000+02:00
diff --git a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -481,7 +481,7 @@ public void setDhcpProviders(final List<DhcpServiceProvider> dhcpProviders) {
      */
     private List<NetworkElement> getNetworkElementsIncludingExtensions() {
         List<Extension> extensions = extensionHelper.listExtensionsByType(Extension.Type.NetworkOrchestrator);
-        if (extensions == null || extensions.isEmpty()) {
+        if (CollectionUtils.isEmpty(extensions)) {
             return networkElements;
         }
         List<NetworkElement> combined = new ArrayList<>(networkElements);

Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ public void setDhcpProviders(final List<DhcpServiceProvider> dhcpProviders) {`
`481`	`481`	`*/`
`482`	`482`	`private List<NetworkElement> getNetworkElementsIncludingExtensions() {`
`483`	`483`	`List<Extension> extensions = extensionHelper.listExtensionsByType(Extension.Type.NetworkOrchestrator);`
`484`		`- if (extensions == null \|\| extensions.isEmpty()) {`
	`484`	`+ if (CollectionUtils.isEmpty(extensions)) {`
`485`	`485`	`return networkElements;`
`486`	`486`	`}`
`487`	`487`	`List<NetworkElement> combined = new ArrayList<>(networkElements);`