address copilot comment

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

server/src/main/java/com/cloud/api/ApiResponseHelper.java

@@ -583,16 +583,7 @@ public DomainResponse createDomainResponse(Domain domain) {
         if (domain.getChildCount() > 0) {
             domainResponse.setHasChild(true);
         }
-        List<ResourceTagJoinVO> tags = ApiDBUtils.listResourceTagViewByResourceUUID(domain.getUuid(),
-                ResourceTag.ResourceObjectType.Domain);
-        if (CollectionUtils.isNotEmpty(tags)) {
-            Set<ResourceTagResponse> tagResponses = new HashSet<>();
-            for (ResourceTagJoinVO tag : tags) {
-                ResourceTagResponse tagResponse = ApiDBUtils.newResourceTagResponse(tag, true);
-                tagResponses.add(tagResponse);
-            }
-            domainResponse.setTags(tagResponses);
-        }
+        populateDomainTags(domain.getUuid(), domainResponse);
         domainResponse.setObjectName("domain");
         return domainResponse;
     }
@@ -3055,6 +3046,20 @@ public static void populateOwner(ControlledViewEntityResponse response, Controll
         response.setDomainPath(getPrettyDomainPath(object.getDomainPath()));
     }
 
+    public static void populateDomainTags(String domainUuid, DomainResponse domainResponse) {
+        List<ResourceTagJoinVO> tags = ApiDBUtils.listResourceTagViewByResourceUUID(domainUuid,
+                ResourceTag.ResourceObjectType.Domain);
+        if (CollectionUtils.isEmpty(tags)) {
+            return;
+        }
+        Set<ResourceTagResponse> tagResponses = new HashSet<>();
+        for (ResourceTagJoinVO tag : tags) {
+            ResourceTagResponse tagResponse = ApiDBUtils.newResourceTagResponse(tag, true);
+            tagResponses.add(tagResponse);
+        }
+        domainResponse.setTags(tagResponses);
+    }
+
     private void populateAccount(ControlledEntityResponse response, long accountId) {
         Account account = ApiDBUtils.findAccountById(accountId);
         if (account == null) {

server/src/main/java/com/cloud/api/query/dao/DomainJoinDaoImpl.java

@@ -115,16 +115,7 @@ public DomainResponse newDomainResponse(ResponseView view, EnumSet<DomainDetails
         }
 
         domainResponse.setDetails(ApiDBUtils.getDomainDetails(domain.getId()));
-        List<ResourceTagJoinVO> tags = ApiDBUtils.listResourceTagViewByResourceUUID(domain.getUuid(),
-                ResourceTag.ResourceObjectType.Domain);
-        if (CollectionUtils.isNotEmpty(tags)) {
-            Set<ResourceTagResponse> tagResponses = new HashSet<>();
-            for (ResourceTagJoinVO tag : tags) {
-                ResourceTagResponse tagResponse = ApiDBUtils.newResourceTagResponse(tag, true);
-                tagResponses.add(tagResponse);
-            }
-            domainResponse.setTags(tagResponses);
-        }
+        ApiResponseHelper.populateDomainTags(domain.getUuid(), domainResponse);
         domainResponse.setObjectName("domain");
 
         return domainResponse;