Skip to content

Commit 90d7b7b

Browse files
apply suggestions and fix bugs
1 parent e35b68f commit 90d7b7b

7 files changed

Lines changed: 2 additions & 15 deletions

File tree

api/src/main/java/org/apache/cloudstack/api/command/admin/user/RegisterUserKeysCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public List<Map<String, Object>> getRules() {
139139
String description = detail.get(ApiConstants.DESCRIPTION);
140140
if (StringUtils.isNotEmpty(description)) {
141141
if (description.length() > 255) {
142-
throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Description cannot be longer than 255 characters.");
142+
throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Rule description cannot be longer than 255 characters.");
143143
}
144144
ruleDetails.put(ApiConstants.DESCRIPTION, description);
145145
}

ui/public/locales/en.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3963,7 +3963,6 @@
39633963
"message.success.create.keypair": "Successfully created SSH key pair",
39643964
"message.success.create.kubernetes.cluster": "Successfully created Kubernetes Cluster",
39653965
"message.success.create.l2.network": "Successfully created L2 Network",
3966-
"message.success.create.password": "Successfully created API key pair for user",
39673966
"message.success.create.snapshot.from.vmsnapshot": "Successfully created Snapshot from Instance Snapshot",
39683967
"message.success.create.template": "Successfully created Template",
39693968
"message.success.create.user": "Successfully created User",

ui/public/locales/pt_BR.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3558,7 +3558,6 @@
35583558
"message.success.create.keypair": "Par de chaves SSH criado com sucesso",
35593559
"message.success.create.kubernetes.cluster": "Cluster Kubernetes criado com sucesso",
35603560
"message.success.create.l2.network": "Rede L2 criada com sucesso",
3561-
"message.success.create.password": "Par de chave de acesso \u00e0 API criada com sucesso",
35623561
"message.success.create.sharedfs": "Sistema de Arquivos Compartilhado criado com sucesso",
35633562
"message.success.create.snapshot.from.vmsnapshot": "Snapshot de volume a partir da snapshot de VM criada com sucesso",
35643563
"message.success.create.template": "Template criado com sucesso",

ui/src/components/view/ApiKeyPairsTab.vue

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,18 +137,14 @@
137137
</template>
138138
<script>
139139
import { getAPI, postAPI } from '@/api'
140-
import Status from '@/components/widgets/Status'
141140
import TooltipButton from '@/components/widgets/TooltipButton'
142141
import BulkActionView from '@/components/view/BulkActionView.vue'
143142
import eventBus from '@/config/eventBus'
144-
import OwnershipSelection from '@/views/compute/wizard/OwnershipSelection.vue'
145143
import GenerateApiKeyPair from '@/views/iam/GenerateApiKeyPair.vue'
146144
147145
export default {
148146
name: 'ApiKeyPairsTab',
149147
components: {
150-
OwnershipSelection,
151-
Status,
152148
TooltipButton,
153149
BulkActionView,
154150
GenerateApiKeyPair
@@ -301,7 +297,6 @@ export default {
301297
isFetchData: false
302298
},
303299
successMethod: () => {
304-
console.log('success method')
305300
eventBus.emit('update-resource-state', { selectedItems: this.selectedItems, resource: keypair.id, state: 'success' })
306301
},
307302
catchMethod: () => {

ui/src/views/AutogenView.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,6 @@ export default {
11191119
this.loading = true
11201120
if (this.$route.path.startsWith('/cniconfiguration')) {
11211121
params.forcks = true
1122-
console.log('here')
11231122
}
11241123
if (this.$route.params && this.$route.params.id) {
11251124
params.id = this.$route.params.id

ui/src/views/iam/ApiKeyPairPermissionTable.vue

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
:filterOption="filterOption"
2929
:options="apis"
3030
v-model:value="newRule"
31-
:placeholder="$t('label.rule')"
32-
:class="{'rule-dropdown-error' : newRuleSelectError}" />
31+
:placeholder="$t('label.rule')" />
3332
</div>
3433
<div class="rules-table__col rules-table__col--permission">
3534
<permission-editable
@@ -197,7 +196,6 @@ export default {
197196
newRule: '',
198197
newRulePermission: 'allow',
199198
newRuleDescription: '',
200-
newRuleSelectError: false,
201199
drag: false,
202200
apis: [],
203201
currRules: new Set(),

ui/src/views/iam/GenerateApiKeyPair.vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,6 @@ export default {
139139
this.formRef = ref()
140140
this.form = reactive({})
141141
},
142-
isValidValueForKey (obj, key) {
143-
return key in obj && obj[key] != null
144-
},
145142
buildRequestParams () {
146143
const values = toRaw(this.form)
147144
this.loading = true

0 commit comments

Comments
 (0)