vmware: Persist empty values instead of null (#5748)

nvazquez · web-flow · commit 946f9156e513 · 2022-01-08T08:58:46.000+05:30
This PR allows deploying VMware appliances missing default values on some properties Fixes: #5747
diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -4416,6 +4416,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
                             value = DBEncryptionUtil.encrypt(value);
                         }
                     }
+                } else if (value == null) {
+                    value = "";
                 }
                 if (s_logger.isTraceEnabled()) {
                     s_logger.trace(String.format("setting property '%s' as '%s' with value '%s'", key, detailKey, value));

Original file line number	Diff line number	Diff line change
`@@ -4416,6 +4416,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user`
`4416`	`4416`	`value = DBEncryptionUtil.encrypt(value);`
`4417`	`4417`	`}`
`4418`	`4418`	`}`
	`4419`	`+ } else if (value == null) {`
	`4420`	`+ value = "";`
`4419`	`4421`	`}`
`4420`	`4422`	`if (s_logger.isTraceEnabled()) {`
`4421`	`4423`	`s_logger.trace(String.format("setting property '%s' as '%s' with value '%s'", key, detailKey, value));`