use StringUtils.getPreferredCharset()

Daan Hoogland · Daan Hoogland · commit a08b7254d0c4 · 2025-08-07T08:58:31.000+02:00
diff --git a/utils/src/main/java/com/cloud/utils/ConstantTimeComparator.java b/utils/src/main/java/com/cloud/utils/ConstantTimeComparator.java
@@ -36,7 +36,6 @@ public static boolean compareBytes(byte[] b1, byte[] b2) {
     }
 
     public static boolean compareStrings(String s1, String s2) {
-        final Charset encoding = Charset.forName("UTF-8");
-        return compareBytes(s1.getBytes(encoding), s2.getBytes(encoding));
+        return compareBytes(s1.getBytes(StringUtils.getPreferredCharset()), s2.getBytes(StringUtils.getPreferredCharset()));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ public static boolean compareBytes(byte[] b1, byte[] b2) {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public static boolean compareStrings(String s1, String s2) {`
`39`		`- final Charset encoding = Charset.forName("UTF-8");`
`40`		`- return compareBytes(s1.getBytes(encoding), s2.getBytes(encoding));`
	`39`	`+ return compareBytes(s1.getBytes(StringUtils.getPreferredCharset()), s2.getBytes(StringUtils.getPreferredCharset()));`
`41`	`40`	`}`
`42`	`41`	`}`