Skip to content

Commit a756b10

Browse files
more optimisations
1 parent 5431168 commit a756b10

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,11 +1003,10 @@ public void updateLBHealthChecks(Scheme scheme) throws ResourceUnavailableExcept
10031003
private boolean isRollBackAllowedForProvider(LoadBalancerVO loadBalancer) {
10041004
Network network = _networkDao.findById(loadBalancer.getNetworkId());
10051005
List<Provider> provider = _networkMgr.getProvidersForServiceInNetwork(network, Service.Lb);
1006-
if (provider == null || provider.isEmpty()) {
1006+
if (CollectionUtils.isEmpty(provider)) {
10071007
return false;
10081008
}
1009-
return provider.get(0) == Provider.Netscaler || provider.get(0) == Provider.F5BigIp ||
1010-
provider.get(0) == Provider.VirtualRouter || provider.get(0) == Provider.VPCVirtualRouter;
1009+
return List.of(Provider.Netscaler, Provider.F5BigIp, Provider.VirtualRouter, Provider.VPCVirtualRouter).contains(provider.get(0));
10111010
}
10121011

10131012
@Override

0 commit comments

Comments
 (0)