Skip to content

Commit b166bfd

Browse files
committed
docs(backup): comment on TakeBackupCommand.executeInSequence=false
Per Daan's review on PR #12847, document inline why we return false from executeInSequence — the same reasoning previously only given in the PR thread. The comment explains the design intent (parallel dispatch with DeleteBackupCommand) and the safety case (per-VM on-NAS paths + per-script NFS mount lifecycle).
1 parent 4338c9c commit b166bfd

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

core/src/main/java/org/apache/cloudstack/backup/TakeBackupCommand.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ public void setVolumePaths(List<String> volumePaths) {
8989

9090
@Override
9191
public boolean executeInSequence() {
92+
// Returning false lets the KVM agent dispatch this command in parallel with
93+
// other backup commands (notably DeleteBackupCommand). A long-running snapshot
94+
// copy must not block a concurrent delete on a different VM's backup. Safe
95+
// because each backup operates on its own on-NAS path (named after the VM
96+
// uuid + timestamp) and the NFS mount lifecycle is per-script-invocation,
97+
// not shared — so there is no path-level contention between parallel runs.
9298
return false;
9399
}
94100
}

0 commit comments

Comments
 (0)