Skip to content

Commit b2cd0bf

Browse files
committed
fix(backup): restrict parallel execution to TakeBackup only
Revert DeleteBackupCommand to executeInSequence()=true per @abh1sar's review. Backup creation is safe to parallelize across VMs because each VM writes to its own NAS path. Backup deletion is not safe to parallelize the same way: incremental chains share parent qcow2 files on the NAS, and concurrent deletions of sibling or descendant nodes can race on the underlying file references and the chain metadata. Until that's modeled explicitly, keep DeleteBackup serialized. TakeBackup parallelization stands.
1 parent 81f5dd2 commit b2cd0bf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

core/src/main/java/org/apache/cloudstack/backup/DeleteBackupCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,6 @@ public void setMountOptions(String mountOptions) {
7171

7272
@Override
7373
public boolean executeInSequence() {
74-
return false;
74+
return true;
7575
}
7676
}

0 commit comments

Comments
 (0)