CID-1175714 casts before bit shift

DaanHoogland · DaanHoogland · commit b5625c05d04c · 2015-11-16T18:25:31.000+01:00
diff --git a/services/console-proxy-rdp/rdpconsole/src/main/java/streamer/ByteBuffer.java b/services/console-proxy-rdp/rdpconsole/src/main/java/streamer/ByteBuffer.java
@@ -418,7 +418,10 @@ public long readUnsignedInt() {
     }
 
     protected static long calculateUnsignedInt(byte value1, byte value2, byte value3, byte value4) {
-        return (calculateUnsignedByte(value1) << 24) + (calculateUnsignedByte(value2) << 16) + (calculateUnsignedByte(value3) << 8) + calculateUnsignedByte(value4);
+        return (((long)calculateUnsignedByte(value1)) << 24)
+                + (((long)calculateUnsignedByte(value2)) << 16)
+                + (((long)calculateUnsignedByte(value3)) << 8)
+                + calculateUnsignedByte(value4);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,10 @@ public long readUnsignedInt() {`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`protected static long calculateUnsignedInt(byte value1, byte value2, byte value3, byte value4) {`
`421`		`- return (calculateUnsignedByte(value1) << 24) + (calculateUnsignedByte(value2) << 16) + (calculateUnsignedByte(value3) << 8) + calculateUnsignedByte(value4);`
	`421`	`+ return (((long)calculateUnsignedByte(value1)) << 24)`
	`422`	`+ + (((long)calculateUnsignedByte(value2)) << 16)`
	`423`	`+ + (((long)calculateUnsignedByte(value3)) << 8)`
	`424`	`+ + calculateUnsignedByte(value4);`
`422`	`425`	`}`
`423`	`426`
`424`	`427`	`/**`