Skip to content

Commit d6e7a9f

Browse files
committed
Add additional unit tests
1 parent b0ba9a1 commit d6e7a9f

1 file changed

Lines changed: 36 additions & 0 deletions

File tree

plugins/database/quota/src/test/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImplTest.java

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@
3838
import com.cloud.user.AccountManager;
3939
import com.cloud.user.UserVO;
4040
import com.cloud.utils.Pair;
41+
import com.cloud.utils.db.EntityManager;
4142
import com.cloud.utils.exception.CloudRuntimeException;
43+
import org.apache.cloudstack.api.InternalIdentity;
4244
import org.apache.cloudstack.api.ServerApiException;
4345
import org.apache.cloudstack.api.command.QuotaConfigureEmailCmd;
4446
import org.apache.cloudstack.api.command.QuotaCreditsListCmd;
@@ -186,6 +188,9 @@ public class QuotaResponseBuilderImplTest extends TestCase {
186188
@Mock
187189
User callerUserMock;
188190

191+
@Mock
192+
EntityManager entityManagerMock;
193+
189194
@Before
190195
public void setup() {
191196
CallContext.register(callerUserMock, callerAccountMock);
@@ -1135,4 +1140,35 @@ public void getDomainIdsForQuotaStatementTestThrowsAccessDeniedForProvidedDomain
11351140
() -> quotaResponseBuilderSpy.getDomainIdsForQuotaStatement(null, 5L, false));
11361141
Mockito.verify(accountManagerMock).checkAccess(callerAccountMock, domainVoMock);
11371142
}
1143+
1144+
@Test(expected = InvalidParameterValueException.class)
1145+
public void retrieveResourceTestThrowsExceptionForInvalidUsageType() {
1146+
Integer invalidUsageType = 999;
1147+
quotaResponseBuilderSpy.retrieveResource("validUuid", invalidUsageType);
1148+
}
1149+
1150+
@Test
1151+
public void retrieveResourceTestReturnsNullForNonexistentResource() {
1152+
String invalidUuid = "nonexistentUuid";
1153+
Integer validUsageType = QuotaTypes.ALLOCATED_VM;
1154+
1155+
Mockito.doReturn(null).when(entityManagerMock).findByUuidIncludingRemoved(Mockito.any(), Mockito.eq(invalidUuid));
1156+
InternalIdentity result = quotaResponseBuilderSpy.retrieveResource(invalidUuid, validUsageType);
1157+
1158+
Assert.assertNull(result);
1159+
}
1160+
1161+
@Test
1162+
public void retrieveResourceTestReturnsCorrectResource() {
1163+
String validUuid = "validUuid";
1164+
Integer validUsageType = QuotaTypes.ALLOCATED_VM;
1165+
InternalIdentity mockResource = Mockito.mock(InternalIdentity.class);
1166+
1167+
Mockito.doReturn(mockResource).when(entityManagerMock).findByUuidIncludingRemoved(Mockito.any(), Mockito.eq(validUuid));
1168+
1169+
InternalIdentity result = quotaResponseBuilderSpy.retrieveResource(validUuid, validUsageType);
1170+
1171+
Assert.assertNotNull(result);
1172+
Assert.assertEquals(mockResource, result);
1173+
}
11381174
}

0 commit comments

Comments
 (0)