checktyle: verify package name matches directory structure

Author: marcaurele

pom.xml

@@ -108,7 +108,8 @@
     <cs.target.dir>target</cs.target.dir>
     <cs.daemon.version>1.1.0</cs.daemon.version>
     <cs.jna.version>4.0.0</cs.jna.version>
-    <cs.checkstyle.version>2.17</cs.checkstyle.version>
+    <cs.checkstyle.version>3.0.0</cs.checkstyle.version>
+    <cs.checkstyle-lib.version>8.7</cs.checkstyle-lib.version>
     <cs.mycila.license.version>2.11</cs.mycila.license.version>
     <cs.findbugs.version>3.0.3</cs.findbugs.version>
     <cs.javadoc.version>2.10.3</cs.javadoc.version>
@@ -619,6 +620,11 @@
               <artifactId>checkstyle</artifactId>
               <version>${project.version}</version>
             </dependency>
+            <dependency>
+              <groupId>com.puppycrawl.tools</groupId>
+              <artifactId>checkstyle</artifactId>
+              <version>${cs.checkstyle-lib.version}</version>
+            </dependency>
           </dependencies>
           <executions>
             <execution>
@@ -634,9 +640,11 @@
             <configLocation>cloud-style.xml</configLocation>
             <consoleOutput>true</consoleOutput>
             <includeTestSourceDirectory>true</includeTestSourceDirectory>
-            <sourceDirectory>${project.basedir}</sourceDirectory>
+            <sourceDirectories>
+              <sourceDirectory>${project.basedir}</sourceDirectory>
+            </sourceDirectories>
             <includes>**\/*.java</includes>
-            <excludes>**\/deps\/,**\/test\/,**\/target\/,**\/bin\/,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat,**\/apidoc\/</excludes>
+            <excludes>**\/deps\/,**\/test\/,**\/target\/,**\/bin\/,**\/*.xml,**\/*.ini,**\/*.sh,**\/*.bat,**\/apidoc\/,**\/generated-sources\/**\/*</excludes>
           </configuration>
         </plugin>
         <plugin>

tools/checkstyle/pom.xml

@@ -31,7 +31,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.13</version>
+          <version>3.0.0</version>
           <executions>
             <execution>
               <phase>none</phase>

tools/checkstyle/src/main/resources/cloud-style.xml

@@ -21,7 +21,6 @@
     <module name="LineLength">
       <property name="max" value="1024" />
     </module>
-
     <module name="RedundantImport" />
     <module name="UnusedImports" />
     <module name="MemberName">
@@ -36,12 +35,13 @@
 	<module name="ConstantName">
 	  <property name="format" value="^[a-zA-Z][a-zA-Z0-9_]*$"/>
 	</module>
-
     <module name="PackageName" />
+    <module name="PackageDeclaration"><property name="matchDirectoryStructure" value="true"/></module>
     <module name="ParameterName" />
     <module name="TypeName" />
     <module name="AvoidStarImport" />
   </module>
+
   <module name="RegexpSingleline">
     <!-- \s matches whitespace character, $ matches end of line. -->
     <property name="format" value="\s+$" />