Skip to content

Commit f29002b

Browse files
author
Pearl Dsilva
committed
address comment
1 parent e3f1ccb commit f29002b

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public KVMPhysicalDisk createDiskFromTemplate(KVMPhysicalDisk template,
207207
}
208208

209209
@Override
210-
public void createTemplateOnClvmNg(String templatePath, String templateUuid, int timeout, KVMStoragePool pool) {
210+
public void createTemplate(String templatePath, String templateUuid, int timeout, KVMStoragePool pool) {
211211
String vgName = getVgName(pool.getLocalPath());
212212
String lvName = "template-" + templateUuid;
213213
String lvPath = "/dev/" + vgName + "/" + lvName;

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ public KVMPhysicalDisk createPhysicalDiskFromDirectDownloadTemplate(String templ
527527

528528
public void createTemplateOnClvmNg(String templatePath, String templateUuid, int timeout, KVMStoragePool pool) {
529529
StorageAdaptor adaptor = getStorageAdaptor(pool.getType());
530-
adaptor.createTemplateOnClvmNg(templatePath, templateUuid, timeout, pool);
530+
adaptor.createTemplate(templatePath, templateUuid, timeout, pool);
531531
}
532532

533533
public Ternary<Boolean, Map<String, String>, String> prepareStorageClient(StoragePoolType type, String uuid, Map<String, String> details) {

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,7 @@ default Pair<Boolean, String> unprepareStorageClient(String uuid, Map<String, St
149149
return new Pair<>(true, "");
150150
}
151151

152-
/**
153-
* Creates a template LV on a CLVM_NG pool from the given QCOW2 template file.
154-
* Default implementation is a no-op; overridden by ClvmStorageAdaptor.
155-
*/
156-
default void createTemplateOnClvmNg(String templatePath, String templateUuid, int timeout, KVMStoragePool pool) {
157-
// no-op for non-CLVM adaptors
152+
default void createTemplate(String templatePath, String templateUuid, int timeout, KVMStoragePool pool) {
153+
// no-op
158154
}
159155
}

0 commit comments

Comments
 (0)