Merge branch 'fix-backup-detail' into '4.20.0.0-scclouds'

Correção na tabela `backup_details`

Closes #3257

See merge request scclouds/scclouds!1356

Author: SadiJr

engine/schema/src/main/java/org/apache/cloudstack/backup/BackupDetailVO.java

@@ -40,7 +40,7 @@ public class BackupDetailVO implements ResourceDetail {
     @Column(name = "name")
     private String name;
 
-    @Column(name = "value")
+    @Column(name = "value", length = 65536)
     private String value;
 
     @Column(name = "display")

engine/schema/src/main/resources/META-INF/db/schema-42007to42008.sql

@@ -16,3 +16,87 @@
 -- under the License.
 
 -- Schema upgrade from 4.20.0.7 to 4.20.0.8
+
+-- Fix backup details
+
+ALTER TABLE backup_details MODIFY value TEXT NOT NULL;
+
+DELETE FROM `cloud`.`backup_details`
+  WHERE `name`='nics'
+    AND NOT JSON_VALID(`value`)
+    AND `backup_id` IN (
+                        SELECT b.id
+                        FROM `cloud`.`backups` b JOIN `cloud`.`vm_instance` vm ON b.vm_id = vm.id
+                        WHERE vm.removed IS NOT NULL);
+
+DROP PROCEDURE IF EXISTS NormalizeNicDetails;
+CREATE PROCEDURE NormalizeNicDetails()
+BEGIN
+    DECLARE nics_json JSON;
+    DECLARE nic_json JSON;
+    FOR vm IN (
+            SELECT DISTINCT vm_id
+            FROM `cloud`.`backups` b
+            JOIN `cloud`.`backup_details` bd ON b.id = bd.`backup_id`
+            WHERE bd.`name` = 'nics'
+              AND NOT JSON_VALID(bd.`value`)
+              AND b.`removed` IS NULL
+    ) DO
+        SET nics_json = JSON_ARRAY();
+        FOR nic IN (
+                    SELECT net.`uuid` AS network_uuid, n.`ip4_address`, n.`ip6_address`, n.`mac_address`
+                    FROM `cloud`.`nics` n JOIN `cloud`.`networks` net ON n.network_id = net.id
+                    WHERE n.instance_id = vm.vm_id AND n.removed IS NULL
+        ) DO
+            SET nic_json = JSON_OBJECT();
+            IF nic.network_uuid IS NOT NULL THEN
+                SET nic_json = JSON_MERGE(nic_json, JSON_OBJECT('networkid', nic.network_uuid));
+            END IF;
+            IF nic.ip4_address IS NOT NULL THEN
+                SET nic_json = JSON_MERGE(nic_json, JSON_OBJECT('ipaddress', nic.ip4_address));
+            END IF;
+            IF nic.ip6_address IS NOT NULL THEN
+                SET nic_json = JSON_MERGE(nic_json, JSON_OBJECT('ip6address', nic.ip6_address));
+            END IF;
+            IF nic.mac_address IS NOT NULL THEN
+                SET nic_json = JSON_MERGE(nic_json, JSON_OBJECT('macaddress', nic.mac_address));
+            END IF;
+            SET nics_json = JSON_ARRAY_APPEND(nics_json, '$', nic_json);
+        END FOR;
+        UPDATE `cloud`.`backup_details`
+          SET `value` = REPLACE(REPLACE(REPLACE(nics_json,'\\',''), '"{', '{'), '}"', '}')
+          WHERE name = 'nics' AND `backup_id` IN (SELECT id FROM `cloud`.`backups` bs WHERE bs.vm_id = vm.vm_id);
+    END FOR;
+END;
+CALL NormalizeNicDetails();
+DROP NormalizeNicDetails();
+
+DROP PROCEDURE IF EXISTS NormalizeVmSettings;
+CREATE PROCEDURE NormalizeVmSettings ()
+BEGIN
+	DECLARE settings JSON;
+    FOR vm IN (
+                SELECT DISTINCT `vm_id`
+                FROM `cloud`.`backups` b JOIN `cloud`.`backup_details` bd ON b.`id` = bd.`backup_id`
+                WHERE bd.`name` ='vmsettings'
+                  AND NOT JSON_VALID(bd.`value`)
+    ) DO
+        SET settings = JSON_OBJECT();
+        FOR detail IN (
+                        SELECT `name`, `value`
+                        FROM `user_vm_details` uvd
+                        WHERE uvd.`vm_id` = vm.`vm_id`
+        ) DO
+            SET settings = JSON_MERGE(settings, JSON_OBJECT(detail.name, detail.value));
+        END FOR;
+        UPDATE `cloud`.`backup_details`
+        SET `value`=settings
+        WHERE `name` = "vmsettings"
+          AND `backup_id` IN (
+                               SELECT `id`
+                               FROM `cloud`.`backups` bs
+                               WHERE bs.vm_id = vm.vm_id);
+    END FOR;
+END;
+CALL NormalizeVmSettings();
+DROP NormalizeVmSettings();