From f14513995f93e96d7ff2ae9333fdc5c4e1439031 Mon Sep 17 00:00:00 2001 From: Kengne-yvana Date: Fri, 23 Jan 2026 07:25:55 +0100 Subject: [PATCH] FINERACT-2121: BulkImport not working on PostgreSql with Integration Test --- .../BulkImportWorkbookServiceImpl.java | 6 +- ...ortWorkbookServiceImplIntegrationTest.java | 57 +++++++++++++++++++ 2 files changed, 61 insertions(+), 2 deletions(-) create mode 100644 integration-tests/src/test/java/org/apache/fineract/integrationtests/bulkimport/service/BulkImportWorkbookServiceImplIntegrationTest.java diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookServiceImpl.java index d27c9fc46d8..05eef5bed5d 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookServiceImpl.java @@ -247,7 +247,7 @@ public DocumentData getOutputTemplateLocation(String importDocumentId) { final ImportTemplateLocationMapper importTemplateLocationMapper = new ImportTemplateLocationMapper(); final String sql = "select " + importTemplateLocationMapper.schema(); - return this.jdbcTemplate.queryForObject(sql, importTemplateLocationMapper, new Object[] { Integer.parseInt(importDocumentId) }); // NOSONAR + return this.jdbcTemplate.queryForObject(sql, importTemplateLocationMapper, new Object[] { Long.parseLong(importDocumentId) }); } @Override @@ -255,7 +255,9 @@ public Response getOutputTemplate(String importDocumentId) { this.securityContext.authenticatedUser(); final ImportTemplateLocationMapper importTemplateLocationMapper = new ImportTemplateLocationMapper(); final String sql = "select " + importTemplateLocationMapper.schema(); - DocumentData documentData = this.jdbcTemplate.queryForObject(sql, importTemplateLocationMapper, new Object[] { importDocumentId }); // NOSONAR + DocumentData documentData = this.jdbcTemplate.queryForObject(sql, importTemplateLocationMapper, + new Object[] { Long.parseLong(importDocumentId) }); + return buildResponse(documentData); } diff --git a/integration-tests/src/test/java/org/apache/fineract/integrationtests/bulkimport/service/BulkImportWorkbookServiceImplIntegrationTest.java b/integration-tests/src/test/java/org/apache/fineract/integrationtests/bulkimport/service/BulkImportWorkbookServiceImplIntegrationTest.java new file mode 100644 index 00000000000..b6183643131 --- /dev/null +++ b/integration-tests/src/test/java/org/apache/fineract/integrationtests/bulkimport/service/BulkImportWorkbookServiceImplIntegrationTest.java @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fineract.integrationtests.bulkimport.service; + +import static io.restassured.RestAssured.given; +import static org.junit.jupiter.api.Assertions.assertNotNull; + +import io.restassured.builder.RequestSpecBuilder; +import io.restassured.builder.ResponseSpecBuilder; +import io.restassured.http.ContentType; +import io.restassured.specification.RequestSpecification; +import io.restassured.specification.ResponseSpecification; +import org.apache.fineract.integrationtests.common.Utils; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +public class BulkImportWorkbookServiceImplIntegrationTest { + + private ResponseSpecification responseSpec; + private RequestSpecification requestSpec; + + @BeforeEach + public void setup() { + Utils.initializeRESTAssured(); + this.requestSpec = new RequestSpecBuilder().setContentType(ContentType.JSON).build(); + this.requestSpec.header("Authorization", "Basic " + Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey()); + this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200).build(); + } + + @Test + public void testGetOutputTemplateSyntax() { + final String importDocumentId = "1"; + + String jsonResponse = given().spec(requestSpec).queryParam("importDocumentId", importDocumentId).when() + .get("/fineract-provider/api/v1/bulkimport/getOutputTemplate").then().spec(responseSpec).extract().asString(); + + assertNotNull(jsonResponse); + } + +}