Skip to content

Commit fc577c0

Browse files
committed
address comments
1 parent 48e369f commit fc577c0

File tree

15 files changed

+3501
-112
lines changed

15 files changed

+3501
-112
lines changed

Cargo.lock

Lines changed: 60 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bindings/elixir/lib/fluss/native.ex

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,7 @@ defmodule Fluss.Native do
5454
def schema_builder_column(_builder, _name, _data_type), do: :erlang.nif_error(:nif_not_loaded)
5555
def schema_builder_primary_key(_builder, _keys), do: :erlang.nif_error(:nif_not_loaded)
5656
def schema_builder_build(_builder), do: :erlang.nif_error(:nif_not_loaded)
57-
def table_descriptor_new(_schema), do: :erlang.nif_error(:nif_not_loaded)
58-
def table_descriptor_with_bucket_count(_schema, _count), do: :erlang.nif_error(:nif_not_loaded)
59-
60-
def table_descriptor_with_properties(_schema, _properties),
57+
def table_descriptor_new(_schema, _bucket_count, _properties),
6158
do: :erlang.nif_error(:nif_not_loaded)
6259

6360
# Table

bindings/elixir/lib/fluss/table_descriptor.ex

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,10 @@ defmodule Fluss.TableDescriptor do
3434

3535
@spec new!(Fluss.Schema.t(), keyword()) :: t()
3636
def new!(schema, opts \\ []) do
37-
result =
38-
cond do
39-
Keyword.has_key?(opts, :bucket_count) ->
40-
Native.table_descriptor_with_bucket_count(schema, opts[:bucket_count])
37+
bucket_count = Keyword.get(opts, :bucket_count)
38+
properties = Keyword.get(opts, :properties, [])
4139

42-
Keyword.has_key?(opts, :properties) ->
43-
Native.table_descriptor_with_properties(schema, opts[:properties])
44-
45-
true ->
46-
Native.table_descriptor_new(schema)
47-
end
48-
49-
case result do
40+
case Native.table_descriptor_new(schema, bucket_count, properties) do
5041
{:error, reason} -> raise "failed to create table descriptor: #{reason}"
5142
ref -> ref
5243
end

0 commit comments

Comments
 (0)