Search before asking
Description
Problem
The Java client currently has no validation for client.scanner.log.max-poll-records and client.connect-timeout. Setting either of these to 0 makes no practical sense poll() would return nothing and TCP connect would time out immediately but no error is raised at config initialization time.
FlussConfigUtils.validateServerConfigs() already uses validMinValue() to validate server-side numeric configs like default.replication.factor, kv.snapshot.num-retained, and others, but there is no equivalent validation for client-side config options.
Proposed Fix
Add validation in the client initialization path (similar to how server configs are validated in FlussConfigUtils) to enforce:
client.scanner.log.max-poll-records must be > 0
client.connect-timeout must be > 0
Context
This was identified while implementing validation for the Rust client in apache/fluss-rust#449. The Rust client intentionally skips these checks to match Java behavior, pending this fix upstream.
Willingness to contribute
Search before asking
Description
Problem
The Java client currently has no validation for
client.scanner.log.max-poll-recordsandclient.connect-timeout. Setting either of these to 0 makes no practical sense poll() would return nothing and TCP connect would time out immediately but no error is raised at config initialization time.FlussConfigUtils.validateServerConfigs()already usesvalidMinValue()to validate server-side numeric configs likedefault.replication.factor,kv.snapshot.num-retained, and others, but there is no equivalent validation for client-side config options.Proposed Fix
Add validation in the client initialization path (similar to how server configs are validated in
FlussConfigUtils) to enforce:client.scanner.log.max-poll-recordsmust be > 0client.connect-timeoutmust be > 0Context
This was identified while implementing validation for the Rust client in apache/fluss-rust#449. The Rust client intentionally skips these checks to match Java behavior, pending this fix upstream.
Willingness to contribute