[MSHARED-815] Maven Archiver: MavenArchiver.addManifestAttribute does not escape empty lines in value

[jira-importer]

Konrad Windszus opened MSHARED-815 and commented

According to https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#name-value-pairs-and-sections

Groups of name-value pairs are known as a "section". Sections are separated from other sections by empty lines.

Therefore empty lines in attribute values lead to invalid manifests and must somehow be escaped.
As this is not done by default in java.util.jar.Attributes.writeMain(...) the method MavenArchiver.addManifestAttribute(...) should either throw an exception in case of empty lines given to parameter value or escape those empty lines somehow (

maven-archiver/src/main/java/org/apache/maven/archiver/MavenArchiver.java

Line 221 in d454ab3

Manifest.Attribute attr = new Manifest.Attribute( key, value );

).

---

Affects: maven-archiver-3.4.0

Issue Links:

• JCRVLT-324 In case of a long project description in CDATA the resulting MANIFEST.MF is invalid

Remote Links:

• JDK-8222547
  

[jira-importer]

Konrad Windszus commented

To me it seems that the right thing to escape e.g. key "test" with value

This is a paragraph

This is another paragraph

is

test: This is a paragraph
 
 This is another paragraph

There is a space in line 2!

[jira-importer]

Konrad Windszus commented

This is now a confirmed bug (still not fixed even in Java 13 ea) tracked in https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8222547 therefore it would be worth to implement a workaround.