[MSHARED-1416] Review and improve the term "Jdk revision"

[jira-importer]

Michael Osipov opened MSHARED-1416 and commented

This term is confusing because this does not relate the used JDK revision at all. It solely relates to the Java class file version a source file has been compiled. It does not have to be the same version or revision as the JDK. Goal is to deprecate the current one and replace with the term "Java Version".

---

Affects: maven-shared-jar-3.1.0

[jira-importer]

Michael Osipov commented

Gabriel Belingueres, WDYT?

[jira-importer]

Gabriel Belingueres commented

Picking the right name for this is difficult.

As calculated now, the JarData::getJdkRevision() and JarClasses::getJdkRevision() return the maximum target class version of all classes inside the JAR file (for the root content and versioned content). This means to me that this jdkRevision string is the minimum JVM version that can execute all code inside the JAR file, with the warrant that it can't throw  UnsupportedClassVersionError exception,. I don't know if this information can have any other useful meaning or utility.

Having said that, we could rename the method for "what it returns", then it should be called getMaxJavaVersion(), but if named after "what it is useful for", it should be named getMinExecutingJavaVersion().

Of course, any javadoc comment explaining what this value represent is more than welcomed.

[jira-importer]

Michael Osipov commented

Good analysis...need to thing about that.

[jira-importer]

Michael Osipov commented

What about maxJavaClassVersion?

[jira-importer]

Michael Osipov commented

I explicitly do not want to mention runtime because what we do is a static class file analysis....

[jira-importer]

Gabriel Belingueres commented

Yes, I like it. {{{}maxJavaClassVersion{}()}}