Skip to content

Commit 45c0472

Browse files
author
Vincent Potucek
committed
add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable")
1 parent 96efade commit 45c0472

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,17 +293,28 @@ void testResolveNearestWithRanges() throws ArtifactResolutionException, InvalidV
293293
}
294294

295295
@Test
296-
@SuppressWarnings("checkstyle:UnusedLocalVariable")
297296
void testResolveRangeWithManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
298-
ArtifactSpec a = createArtifactSpec("a", "1.0");
299-
ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
297+
String version = "1.0";
298+
ArtifactSpec a = createArtifactSpec("a", version);
299+
String versionRange = "[1.0,3.0]";
300+
ArtifactSpec b = a.addDependency("b", versionRange);
300301

301302
ArtifactSpec managedB = createArtifactSpec("b", "5.0");
302303

303304
ArtifactResolutionResult res = collect(a, managedB.artifact);
304305
assertEquals(
305306
createSet(new Object[] {a.artifact, managedB.artifact}), res.getArtifacts(), "Check artifact list");
306307
assertEquals("5.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");
308+
assertArtifact(a, "a", version, a.artifact.getVersion());
309+
assertArtifact(b, "b", versionRange, b.artifact.getVersionRange().toString());
310+
}
311+
312+
private static void assertArtifact(ArtifactSpec artifactSpec, String artifactId, String version, String artifact) {
313+
assertEquals("test", artifactSpec.artifact.getGroupId());
314+
assertEquals(artifactId, artifactSpec.artifact.getArtifactId());
315+
assertEquals(version, artifact);
316+
assertEquals("compile", artifactSpec.artifact.getScope());
317+
assertEquals("jar", artifactSpec.artifact.getType());
307318
}
308319

309320
@Test

0 commit comments

Comments
 (0)