[S1161] rule: category/java/bestpractices.xml/MissingOverride

Author: Vincent Potucek

.gitignore

@@ -16,4 +16,5 @@
 .factorypath
 .vscode/
 repo/
-/*.svg
+/*.svg
+.pmd/.cache

.pmd/ruleset.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<ruleset name="DOD"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+    <exclude-pattern>.*/compat/maven-compat/.*</exclude-pattern>
+    <rule ref="category/java/bestpractices.xml/MissingOverride" />
+</ruleset>

compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java

@@ -46,6 +46,7 @@ class ArtifactDeployerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "deployer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java

@@ -41,6 +41,7 @@ class ArtifactInstallerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "installer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/TestFileWagon.java

@@ -35,6 +35,7 @@ public class TestFileWagon extends FileWagon {
     private TestTransferListener testTransferListener;
     private boolean insideGet;
 
+    @Override
     @Deprecated
     protected void getTransfer(Resource resource, File destination, InputStream input, boolean closeInput, int maxSize)
             throws TransferFailedException {

compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java

@@ -152,6 +152,7 @@ public String getFileContents(File file, String encoding) throws IOException {
         return FileUtils.fileRead(file, encoding);
     }
 
+    @Override
     protected void finalize() throws Throwable {
         maybeWarnAboutCleanUp();
 

compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java

@@ -48,6 +48,7 @@ protected File projectFile(String groupId, String artifactId) {
     // The local repository for this category of tests
     // ----------------------------------------------------------------------
 
+    @Override
     protected File getLocalRepositoryPath() {
         return getTestFile("target/test-classes/inheritance-repo/" + getTestSeries());
     }

compat/maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

compat/maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java

@@ -80,6 +80,7 @@ public final class PlexusXmlBeanConverter implements PlexusBeanConverter {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     @SuppressWarnings({"unchecked", "rawtypes"})
     public Object convert(final TypeLiteral role, final String value) {
         if (value.trim().startsWith("<")) {

impl/maven-cli/src/main/java/org/apache/maven/cling/extensions/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }