Test unused stream in DefaultPluginXmlFactory#write

Vincent Potucek · Vincent Potucek · commit 8c0fd3cafcc5 · 2025-05-11T13:33:01.000+02:00
diff --git a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest<Model> request) throws XmlWriterException {
         Writer writer = request.getWriter();
         Function<Object, String> inputLocationFormatter = request.getInputLocationFormatter();
         if (writer == null && outputStream == null && path == null) {
-            throw new IllegalArgumentException("writer, output stream, or path must be non null");
+            throw new IllegalArgumentException("writer, outputStream or path must be non null");
         }
         try {
             MavenStaxWriter w = new MavenStaxWriter();
diff --git a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java
@@ -96,7 +96,7 @@ public void write(XmlWriterRequest<PluginDescriptor> request) throws XmlWriterEx
         OutputStream outputStream = request.getOutputStream();
         Writer writer = request.getWriter();
         if (writer == null && outputStream == null && path == null) {
-            throw new IllegalArgumentException("writer, output stream, or path must be non null");
+            throw new IllegalArgumentException("writer, outputStream or path must be non null");
         }
         write(writer, request.getContent(), outputStream, path);
     }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public void write(XmlWriterRequest<Model> request) throws XmlWriterException {`
`121`	`121`	`Writer writer = request.getWriter();`
`122`	`122`	`Function<Object, String> inputLocationFormatter = request.getInputLocationFormatter();`
`123`	`123`	`if (writer == null && outputStream == null && path == null) {`
`124`		`- throw new IllegalArgumentException("writer, output stream, or path must be non null");`
	`124`	`+ throw new IllegalArgumentException("writer, outputStream or path must be non null");`
`125`	`125`	`}`
`126`	`126`	`try {`
`127`	`127`	`MavenStaxWriter w = new MavenStaxWriter();`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public void write(XmlWriterRequest<PluginDescriptor> request) throws XmlWriterEx`
`96`	`96`	`OutputStream outputStream = request.getOutputStream();`
`97`	`97`	`Writer writer = request.getWriter();`
`98`	`98`	`if (writer == null && outputStream == null && path == null) {`
`99`		`- throw new IllegalArgumentException("writer, output stream, or path must be non null");`
	`99`	`+ throw new IllegalArgumentException("writer, outputStream or path must be non null");`
`100`	`100`	`}`
`101`	`101`	`write(writer, request.getContent(), outputStream, path);`
`102`	`102`	`}`