chore: apply SOC to have single AbstractMojo#createFile(File)

Vincent Potucek · Vincent Potucek · commit 9ae5c5e8112f · 2025-06-09T14:32:08.000+02:00
diff --git a/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java b/compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java
@@ -18,6 +18,8 @@
  */
 package org.apache.maven.plugin;
 
+import java.io.File;
+import java.io.IOException;
 import java.util.Map;
 
 import org.apache.maven.plugin.logging.Log;
@@ -176,6 +178,17 @@ public Log getLog() {
         return log;
     }
 
+    protected void createFile(File file) throws MojoExecutionException {
+        getLog().info("Create file: " + file);
+        if (file.getParentFile().mkdirs()) {
+            try {
+                file.createNewFile();
+            } catch (IOException e) {
+                throw new MojoExecutionException(e);
+            }
+        }
+    }
+
     @Override
     public Map getPluginContext() {
         return pluginContext;
diff --git a/its/core-it-suite/src/test/resources/mng-0870/plugin/src/main/java/org/apache/maven/plugin/coreit/LoadMojo.java b/its/core-it-suite/src/test/resources/mng-0870/plugin/src/main/java/org/apache/maven/plugin/coreit/LoadMojo.java
@@ -38,7 +38,6 @@
  */
 
 import java.io.File;
-import java.io.IOException;
 import java.net.URL;
 
 import org.apache.maven.plugin.AbstractMojo;
@@ -81,14 +80,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (url == null) {
             throw new MojoExecutionException("Resource was not found, incomplete plugin class realm");
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + file);
-
-        try {
-            file.getParentFile().mkdirs();
-            file.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + file, e);
-        }
+        createFile(file);
     }
 }
diff --git a/its/core-it-suite/src/test/resources/mng-1088/plugin/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java b/its/core-it-suite/src/test/resources/mng-1088/plugin/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java
@@ -38,7 +38,6 @@
  */
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -66,13 +65,6 @@ public class TouchMojo extends AbstractMojo {
      * @throws MojoExecutionException If the output file could not be created.
      */
     public void execute() throws MojoExecutionException {
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + file);
-
-        try {
-            file.getParentFile().mkdirs();
-            file.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + file, e);
-        }
+        createFile(file);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java
@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -69,16 +68,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java
