try can use automatic resource management

Author: Vincent Potucek

compat/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java

@@ -132,13 +132,7 @@ public boolean checkOutOfDate(Date lastModified) {
 
     @Override
     public String toString() {
-        return "{enabled=" +
-                enabled +
-                ", checksums=" +
-                checksumPolicy +
-                ", updates=" +
-                updatePolicy +
-                '}';
+        return "{enabled=" + enabled + ", checksums=" + checksumPolicy + ", updates=" + updatePolicy + '}';
     }
 
     public ArtifactRepositoryPolicy merge(ArtifactRepositoryPolicy policy) {

compat/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java

@@ -69,7 +69,8 @@ public void storeInLocalRepository(ArtifactRepository localRepository, ArtifactR
 
     protected void updateRepositoryMetadata(ArtifactRepository localRepository, ArtifactRepository remoteRepository)
             throws IOException, XMLStreamException {
-        File metadataFile = new File(localRepository.getBasedir(), localRepository.pathOfLocalRepositoryMetadata(this, remoteRepository));
+        File metadataFile = new File(
+                localRepository.getBasedir(), localRepository.pathOfLocalRepositoryMetadata(this, remoteRepository));
         Metadata metadata = this.metadata;
         if (metadataFile.exists()) {
             try (InputStream input = Files.newInputStream(metadataFile.toPath())) {
@@ -86,7 +87,7 @@ protected void updateRepositoryMetadata(ArtifactRepository localRepository, Arti
                 // to delete on exit
             }
         }
-            writeMetadata(metadata, metadataFile);
+        writeMetadata(metadata, metadataFile);
     }
 
     private void writeMetadata(Metadata metadata, File metadataFile) throws IOException, XMLStreamException {
@@ -145,10 +146,11 @@ public void merge(ArtifactMetadata metadata) {
     }
 
     public String extendedToString() {
-        return lineSeparator() + "Repository Metadata" + lineSeparator() + "--------------------------" +
-                lineSeparator() + "GroupId: " + getGroupId() +
-                lineSeparator() + "ArtifactId: " + getArtifactId() +
-                lineSeparator() + "Metadata Type: " + getClass().getName();
+        return lineSeparator() + "Repository Metadata" + lineSeparator() + "--------------------------"
+                + lineSeparator()
+                + "GroupId: " + getGroupId() + lineSeparator()
+                + "ArtifactId: " + getArtifactId() + lineSeparator()
+                + "Metadata Type: " + getClass().getName();
     }
 
     public int getNature() {

compat/maven-compat/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java

@@ -48,9 +48,9 @@ public String getArtifactId() {
     }
 
     public String extendedToString() {
-        return lineSeparator() + "Artifact Metadata" + lineSeparator() + "--------------------------" +
-                lineSeparator() + "GroupId: " + getGroupId() +
-                lineSeparator() + "ArtifactId: " + getArtifactId() +
-                lineSeparator() + "Metadata Type: " + getClass().getName();
+        return lineSeparator() + "Artifact Metadata" + lineSeparator() + "--------------------------" + lineSeparator()
+                + "GroupId: " + getGroupId() + lineSeparator()
+                + "ArtifactId: " + getArtifactId() + lineSeparator()
+                + "Metadata Type: " + getClass().getName();
     }
 }

compat/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java

@@ -165,8 +165,6 @@ public Version getVersion() {
 
     @Override
     public String toString() {
-        return "[" + getSeverity() + "] " +
-                getMessage() +
-                " @ " + ModelProblemUtils.formatLocation(this, null);
+        return "[" + getSeverity() + "] " + getMessage() + " @ " + ModelProblemUtils.formatLocation(this, null);
     }
 }

compat/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java

@@ -189,11 +189,7 @@ public void setVersion(String version) {
      * @return The effective identifier of the model, never {@code null}.
      */
     public String getId() {
-        return getGroupId() +
-                ':' +
-                getArtifactId() +
-                ':' +
-                getVersion();
+        return getGroupId() + ':' + getArtifactId() + ':' + getVersion();
     }
 
     @Override

compat/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java

@@ -99,7 +99,9 @@ static String toId(Model model) {
      */
     static String toId(String groupId, String artifactId, String version) {
         // not sure about his one. outsmart IDE
-        return groupId != null && !groupId.isEmpty() ? groupId : !artifactId.isEmpty() ? artifactId : !version.isEmpty() ? version : "[unknown-version]";
+        return groupId != null && !groupId.isEmpty()
+                ? groupId
+                : !artifactId.isEmpty() ? artifactId : !version.isEmpty() ? version : "[unknown-version]";
     }
 
     /**

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java

@@ -187,7 +187,7 @@ public void setPluginContext(Map pluginContext) {
         this.pluginContext = pluginContext;
     }
 
-    protected void mkDirForParentFile(File file)  {
+    protected void mkDirForParentFile(File file) {
         getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + file);
         if (file.getParentFile().mkdirs()) {
             getLog().info("[MAVEN-CORE-IT-LOG] Created output file " + file);