chore: singularize AbstractMojo#createFile(File)

Author: Vincent Potucek

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java

@@ -18,6 +18,8 @@
  */
 package org.apache.maven.plugin;
 
+import java.io.File;
+import java.io.IOException;
 import java.util.Map;
 
 import org.apache.maven.plugin.logging.Log;

its/core-it-suite/src/test/resources/mng-0870/plugin/src/main/java/org/apache/maven/plugin/coreit/LoadMojo.java

@@ -38,7 +38,6 @@
  */
 
 import java.io.File;
-import java.io.IOException;
 import java.net.URL;
 
 import org.apache.maven.plugin.AbstractMojo;
@@ -81,14 +80,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (url == null) {
             throw new MojoExecutionException("Resource was not found, incomplete plugin class realm");
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + file);
-
-        try {
-            file.getParentFile().mkdirs();
-            file.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + file, e);
-        }
+        createFile(file);
     }
 }

its/core-it-suite/src/test/resources/mng-1088/plugin/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java

@@ -38,7 +38,6 @@
  */
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -66,13 +65,6 @@ public class TouchMojo extends AbstractMojo {
      * @throws MojoExecutionException If the output file could not be created.
      */
     public void execute() throws MojoExecutionException {
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + file);
-
-        try {
-            file.getParentFile().mkdirs();
-            file.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + file, e);
-        }
+        createFile(file);
     }
 }

its/core-it-support/core-it-component/src/main/java/org/apache/maven/coreit/component/MojoCompanion.java

@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.coreit.component;
+
+import java.io.File;
+import java.io.IOException;
+
+public interface MojoCompanion {
+
+    static void createFile(File file) {
+        if (file.getParentFile().mkdirs()) {
+            try {
+                file.createNewFile();
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+        }
+    }
+}

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java

@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -29,6 +28,8 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.apache.maven.project.MavenProject;
 
+import static org.apache.maven.coreit.component.MojoCompanion.createFile;
+
 /**
  * Creates a text file in the project base directory.
  *
@@ -69,16 +70,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java

@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -29,6 +28,8 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.apache.maven.project.MavenProject;
 
+import static org.apache.maven.coreit.component.MojoCompanion.createFile;
+
 /**
  * Creates a text file in the project base directory.
  *
@@ -69,16 +70,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java

@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -29,6 +28,8 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.apache.maven.project.MavenProject;
 
+import static org.apache.maven.coreit.component.MojoCompanion.createFile;
+
 /**
  * Creates a text file in the project base directory.
  *
@@ -69,16 +70,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java

@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -29,6 +28,8 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.apache.maven.project.MavenProject;
 
+import static org.apache.maven.coreit.component.MojoCompanion.createFile;
+
 /**
  * Creates a text file in the project base directory.
  *
@@ -69,16 +70,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/pom.xml

@@ -56,5 +56,11 @@ under the License.
       <artifactId>maven-compat</artifactId>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-core</artifactId>
+      <version>1.5.18</version>
+      <scope>compile</scope>
+    </dependency>
   </dependencies>
 </project>

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java

@@ -19,7 +19,6 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.IOException;
 
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -29,6 +28,8 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.apache.maven.project.MavenProject;
 
+import static org.apache.maven.coreit.component.MojoCompanion.createFile;
+
 /**
  * Creates a text file in the project base directory.
  *
@@ -69,16 +70,6 @@ public void execute() throws MojoExecutionException, MojoFailureException {
         if (!outputFile.isAbsolute()) {
             outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile();
         }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
-
-        try {
-            outputFile.getParentFile().mkdirs();
-            outputFile.createNewFile();
-        } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + pathname, e);
-        }
-
-        getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
+        createFile(outputFile);
     }
 }