Skip to content

Commit 57eee9d

Browse files
committed
Fix code review.
1 parent d75b813 commit 57eee9d

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

include/pulsar/c/message.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ PULSAR_PUBLIC pulsar_message_t *pulsar_message_create();
4141
* @param from A pointer to the pulsar_message_t object that you want to copy from
4242
* @param to A pointer to the pulsar_message_t object that you want to copy to
4343
*/
44-
PULSAR_PUBLIC void pulsar_message_copy(pulsar_message_t *from, pulsar_message_t *to);
44+
PULSAR_PUBLIC void pulsar_message_copy(const pulsar_message_t *from, pulsar_message_t *to);
4545
PULSAR_PUBLIC void pulsar_message_free(pulsar_message_t *message);
4646

4747
/// Builder

lib/c/c_Message.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
pulsar_message_t *pulsar_message_create() { return new pulsar_message_t; }
2525

26-
void pulsar_message_copy(pulsar_message_t *from, pulsar_message_t *to) {
26+
void pulsar_message_copy(const pulsar_message_t *from, pulsar_message_t *to) {
2727
to->builder = from->builder;
2828
to->message = from->message;
2929
}

tests/c/c_MessageTest.cc

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,11 @@ TEST(c_MessageTest, MessageCopy) {
3030
pulsar_message_t *from = pulsar_message_create();
3131
pulsar_message_set_content(from, "hello", 5);
3232
from->message = from->builder.build();
33-
std::cout << "from: " << (const char *)pulsar_message_get_data(from) << std::endl;
34-
3533
pulsar_message_t *to = pulsar_message_create();
36-
pulsar_message_copy(from, to);
37-
pulsar_message_free(from);
3834

39-
std::cout << "to: " << (const char *)pulsar_message_get_data(to) << std::endl;
40-
ASSERT_STREQ((const char *)pulsar_message_get_data(to), "hello");
35+
pulsar_message_copy(from, to);
36+
ASSERT_STREQ((const char *)pulsar_message_get_data(to), (const char *)pulsar_message_get_data(from));
4137

38+
pulsar_message_free(from);
4239
pulsar_message_free(to);
4340
}

0 commit comments

Comments
 (0)