fileReservedTime配置被覆盖

[zhengm-h]

Before Creating the Bug Report

• I found a bug, not just asking a question, which should be created in GitHub Discussions.

• I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

• I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

linux

RocketMQ version

5.3.2

JDK Version

17.0.18

Describe the Bug

查看broker状态后，配置fileReservedTime 会变成默认的72
命令：

sh bin/mqadmin getBrokerConfig \
  -b localhost:10911 \
  -n localhost:9876 | grep fileReservedTime

日志显示：
AdminBrokerThread_9 - Replace, key: fileReservedTime, value: 168 -> 72

Steps to Reproduce

broker.conf

brokerClusterName = DefaultCluster
brokerName = broker-a
brokerId = 0
deleteWhen = 04
fileReservedTime = 168 
#brokerRole = ASYNC_MASTER
#flushDiskType = ASYNC_FLUSH
brokerRole = SYNC_MASTER 
flushDiskType = SYNC_FLUSH

start.sh

nohup sh bin/mqnamesrv &
sleep 3 
nohup sh bin/mqbroker -n localhost:9876 -c conf/broker.conf -pc conf/proxy.json --enable-proxy &

执行查看命令：

sh bin/mqadmin getBrokerConfig \
  -b localhost:10911 \
  -n localhost:9876 | grep fileReservedTime

问题是：
查看broker状态后（或dashboard点cluster->config），配置fileReservedTime 会变成默认的72
命令：

sh bin/mqadmin getBrokerConfig \
  -b localhost:10911 \
  -n localhost:9876 | grep fileReservedTime

日志显示：
AdminBrokerThread_9 - Replace, key: fileReservedTime, value: 168 -> 72

What Did You Expect to See?

期望按照broker.conf配置中的来，不要变

What Did You See Instead?

无

Additional Context

linux下 local模式部署

[zhengm-h]

proxy.json:

{
  "grpcServerPort": 18081,
  "remotingListenPort": 18080
}

[RockteMQ-AI]

Issue Evaluation

Category: type/bug | Status: Confirmed

The reported issue has been verified against the current codebase.

Root Cause: When running with --enable-proxy (local/embedded mode), the mqbroker startup script embeds a full BrokerController inside the Proxy process. The broker.conf values are loaded into the standalone broker's config objects, but the embedded broker's MessageStoreConfig instance is not fully initialized from broker.conf — so fileReservedTime remains at its default value of 72.

When mqadmin getBrokerConfig is executed, it hits AdminBrokerProcessor.getBrokerConfig() → Configuration.getAllConfigsInternal(), which re-merges the live config-object properties back into the cached allConfigs map. Since the embedded MessageStoreConfig.fileReservedTime is 72 at runtime, the merge overwrites the cached 168 from broker.conf, producing the log line:

Replace, key: fileReservedTime, value: 168  -> 72

Impact: The displayed config value diverges from what was configured. The actual file retention behavior depends on which config object the store layer reads at runtime — but the config drift itself is a correctness issue.

Severity: Medium — affects observability and may cause confusion; actual file retention depends on which config path the CommitLog deletion logic uses.

Key files involved:

• broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java (getBrokerConfig handler)
• remoting/src/main/java/org/apache/rocketmq/remoting/Configuration.java (getAllConfigsInternal, merge)
• broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java (embedded broker wiring)
• store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java (default fileReservedTime = 72)

Note: The Proxy module itself does not write or trigger config updates. The issue is in how the embedded BrokerController is initialized in --enable-proxy local mode.

An automated fix proposal can be generated if the community confirms the approach. Reply /approve to proceed with PR generation.

---

Automated evaluation by RockteMQ-AI

[zhengm-h]

如何解决呢，或如何避免呢，需要单独配置proxy.json吗

[zhengm-h]

/approve

[AliasJeff]

Hi, I opened a PR to trim config values before type conversion, this should fix this issue