Skip to content

Commit 7946dce

Browse files
committed
fix expected test output
1 parent 14188ec commit 7946dce

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2Suite.scala

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,14 @@ class DataSourceV2Suite extends QueryTest with SharedSparkSession with AdaptiveS
313313
Seq(
314314
// with no partitioning and no order, we expect shuffling AND sorting
315315
(None, None, (true, true), (true, true)),
316-
// partitioned by i and no order, we expect NO shuffling BUT sorting
317-
(Some("i"), None, (false, true), (false, true)),
316+
// partitioned by i and no order,
317+
// we expect NO shuffling AND sorting for groupBy BUT sorting for window function
318+
(Some("i"), None, (false, false), (false, true)),
318319
// partitioned by i and in-partition sorted by i,
319320
// we expect NO shuffling AND sorting for groupBy but sorting for window function
320321
(Some("i"), Some("i"), (false, false), (false, true)),
321-
// partitioned by i and in-partition sorted by j, we expect NO shuffling BUT sorting
322-
(Some("i"), Some("j"), (false, true), (false, true)),
322+
// partitioned by i and in-partition sorted by j, we expect NO shuffling NOR sorting
323+
(Some("i"), Some("j"), (false, false), (false, false)),
323324
// partitioned by i and in-partition sorted by i,j, we expect NO shuffling NOR sorting
324325
(Some("i"), Some("i,j"), (false, false), (false, false)),
325326
// partitioned by j and in-partition sorted by i, we expect shuffling AND sorting
@@ -346,6 +347,7 @@ class DataSourceV2Suite extends QueryTest with SharedSparkSession with AdaptiveS
346347
groupBy.toDF(),
347348
Seq(Row(1, 2), Row(2, 1), Row(3, 1), Row(4, 2))
348349
)
350+
groupBy.explain()
349351

350352
val (shuffleExpected, sortExpected) = groupByExpects
351353
assert(collectFirst(groupBy.queryExecution.executedPlan) {

0 commit comments

Comments
 (0)