fix(python): [1/3] improve in-memory size estimation for queue items#4281
Draft
yunyad wants to merge 2 commits intoapache:mainfrom
Draft
fix(python): [1/3] improve in-memory size estimation for queue items#4281yunyad wants to merge 2 commits intoapache:mainfrom
yunyad wants to merge 2 commits intoapache:mainfrom
Conversation
yunyad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR improves the in-memory size estimation logic in
LinkedBlockingMultiQueue.Previously, queue node memory accounting used
sys.getsizeof(item), which may underestimate the actual memory usage of Python data items, especially when the item contains a frame-based payload.This PR adds
_estimate_in_mem_size(item)and replaces the previous directsys.getsizeof(item)call. The new logic prefers frame-level byte size information when available, and falls back tosys.getsizeof(item)otherwise.Any related issues, documentation, discussions?
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
No.