Skip to content

Commit ab2c8c4

Browse files
committed
fix analysis issues
1 parent 2a3c6ba commit ab2c8c4

3 files changed

Lines changed: 35 additions & 34 deletions

File tree

packages/_ardera_common_libc_bindings/lib/src/libc_functions.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ typedef SymbolLookupFn = ffi.Pointer<T> Function<T extends ffi.NativeType>(Strin
1919
class LibCArm extends LibC {
2020
final backend.LibCArm _backend;
2121

22-
LibCArm.fromLookup(SymbolLookupFn _lookup)
22+
LibCArm.fromLookup(super._lookup)
2323
: _backend = backend.LibCArm.fromLookup(_lookup),
24-
super._fromLookup(_lookup);
24+
super._fromLookup();
2525

2626
@override
2727
int bind(int __fd, ffi.Pointer<sockaddr> __addr, int __len) {
@@ -222,9 +222,9 @@ class LibCArm extends LibC {
222222
class LibCArm64 extends LibC {
223223
final backend.LibCArm64 _backend;
224224

225-
LibCArm64.fromLookup(SymbolLookupFn _lookup)
225+
LibCArm64.fromLookup(super._lookup)
226226
: _backend = backend.LibCArm64.fromLookup(_lookup),
227-
super._fromLookup(_lookup);
227+
super._fromLookup();
228228

229229
@override
230230
int bind(int __fd, ffi.Pointer<sockaddr> __addr, int __len) {
@@ -425,9 +425,9 @@ class LibCArm64 extends LibC {
425425
class LibCI386 extends LibC {
426426
final backend.LibCI386 _backend;
427427

428-
LibCI386.fromLookup(SymbolLookupFn _lookup)
428+
LibCI386.fromLookup(super._lookup)
429429
: _backend = backend.LibCI386.fromLookup(_lookup),
430-
super._fromLookup(_lookup);
430+
super._fromLookup();
431431

432432
@override
433433
int bind(int __fd, ffi.Pointer<sockaddr> __addr, int __len) {
@@ -628,9 +628,9 @@ class LibCI386 extends LibC {
628628
class LibCAmd64 extends LibC {
629629
final backend.LibCAmd64 _backend;
630630

631-
LibCAmd64.fromLookup(SymbolLookupFn _lookup)
631+
LibCAmd64.fromLookup(super._lookup)
632632
: _backend = backend.LibCAmd64.fromLookup(_lookup),
633-
super._fromLookup(_lookup);
633+
super._fromLookup();
634634

635635
@override
636636
int bind(int __fd, ffi.Pointer<sockaddr> __addr, int __len) {

packages/flutterpi_gstreamer_video_player/example/lib/main.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,24 +39,24 @@ class _ExampleVideoPageState extends State<ExampleVideoPage> {
3939
autoInitialize: true,
4040
autoPlay: true,
4141
looping: true,
42-
additionalOptions: (context) {
42+
additionalOptions: (_) {
4343
return [
4444
OptionItem(
45-
onTap: () {
45+
onTap: (_) {
4646
_controller.stepForward();
4747
},
4848
iconData: Icons.arrow_right,
4949
title: 'Step Forward',
5050
),
5151
OptionItem(
52-
onTap: () {
52+
onTap: (_) {
5353
_controller.stepBackward();
5454
},
5555
iconData: Icons.arrow_left,
5656
title: 'Step Backward',
5757
),
5858
OptionItem(
59-
onTap: () {},
59+
onTap: (_) {},
6060
iconData: Icons.fast_forward_outlined,
6161
title: 'Fast Seek',
6262
),
@@ -120,7 +120,8 @@ class _CameraViewPageState extends State<CameraViewPage> {
120120
}
121121

122122
class _VideoApp extends StatefulWidget {
123-
const _VideoApp({Key? key}) : super(key: key);
123+
// ignore: unused_element_parameter
124+
const _VideoApp({super.key}) : super();
124125

125126
@override
126127
_VideoAppState createState() => _VideoAppState();

packages/flutterpi_gstreamer_video_player/lib/src/platform.dart

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ class FlutterpiVideoPlayer extends VideoPlayerPlatform {
3333
}
3434

3535
@override
36-
Future<void> dispose(int textureId) async {
37-
return await _invoke('dispose', textureId);
36+
Future<void> dispose(int playerId) async {
37+
return await _invoke('dispose', playerId);
3838
}
3939

4040
static const pipelineUrlScheme = 'gstreamerPipeline';
@@ -89,30 +89,30 @@ class FlutterpiVideoPlayer extends VideoPlayerPlatform {
8989
}
9090

9191
@override
92-
Future<void> setLooping(int textureId, bool looping) async {
93-
return await _invoke('setLooping', [textureId, looping]);
92+
Future<void> setLooping(int playerId, bool looping) async {
93+
return await _invoke('setLooping', [playerId, looping]);
9494
}
9595

9696
@override
97-
Future<void> play(int textureId) async {
98-
return await _invoke('play', textureId);
97+
Future<void> play(int playerId) async {
98+
return await _invoke('play', playerId);
9999
}
100100

101101
@override
102-
Future<void> pause(int textureId) async {
103-
return await _invoke('pause', textureId);
102+
Future<void> pause(int playerId) async {
103+
return await _invoke('pause', playerId);
104104
}
105105

106106
@override
107-
Future<void> setVolume(int textureId, double volume) async {
108-
return await _invoke('setVolume', [textureId, volume]);
107+
Future<void> setVolume(int playerId, double volume) async {
108+
return await _invoke('setVolume', [playerId, volume]);
109109
}
110110

111111
@override
112-
Future<void> setPlaybackSpeed(int textureId, double speed) async {
112+
Future<void> setPlaybackSpeed(int playerId, double speed) async {
113113
assert(speed > 0);
114114

115-
return await _invoke('setPlaybackSpeed', [textureId, speed]);
115+
return await _invoke('setPlaybackSpeed', [playerId, speed]);
116116
}
117117

118118
/// Controls the behaviour of [seekTo]. (Dirty workaround because sanely extending VideoPlayerController is hard.)
@@ -124,19 +124,19 @@ class FlutterpiVideoPlayer extends VideoPlayerPlatform {
124124
var seekMode = SeekMode.normal;
125125

126126
@override
127-
Future<void> seekTo(int textureId, Duration position) async {
127+
Future<void> seekTo(int playerId, Duration position) async {
128128
late Future<void> future;
129129

130130
switch (seekMode) {
131131
case SeekMode.normal:
132132
future = _invoke(
133133
'seekTo',
134-
[textureId, position.inMilliseconds],
134+
[playerId, position.inMilliseconds],
135135
);
136136
break;
137137
case SeekMode.fast:
138138
try {
139-
future = _invoke('fastSeek', [textureId, position.inMilliseconds]);
139+
future = _invoke('fastSeek', [playerId, position.inMilliseconds]);
140140
} finally {
141141
seekMode = SeekMode.normal;
142142
}
@@ -151,14 +151,14 @@ class FlutterpiVideoPlayer extends VideoPlayerPlatform {
151151
}
152152

153153
@override
154-
Future<Duration> getPosition(int textureId) async {
155-
final millis = await _invoke('getPosition', textureId);
154+
Future<Duration> getPosition(int playerId) async {
155+
final millis = await _invoke('getPosition', playerId);
156156
return Duration(milliseconds: millis);
157157
}
158158

159159
@override
160-
Stream<VideoEvent> videoEventsFor(int textureId) {
161-
return _eventChannelFor(textureId).receiveBroadcastStream().map((dynamic event) {
160+
Stream<VideoEvent> videoEventsFor(int playerId) {
161+
return _eventChannelFor(playerId).receiveBroadcastStream().map((dynamic event) {
162162
final Map<dynamic, dynamic> map = event as Map<dynamic, dynamic>;
163163
switch (map['event']) {
164164
case 'initialized':
@@ -190,8 +190,8 @@ class FlutterpiVideoPlayer extends VideoPlayerPlatform {
190190
}
191191

192192
@override
193-
Widget buildView(int textureId) {
194-
return Texture(textureId: textureId);
193+
Widget buildView(int playerId) {
194+
return Texture(textureId: playerId);
195195
}
196196

197197
@override

0 commit comments

Comments
 (0)