From 80bd746706b3ecacd713c1e71ab6a0034342078e Mon Sep 17 00:00:00 2001 From: Hannes Winkler Date: Mon, 6 Apr 2026 13:40:12 +0200 Subject: [PATCH 1/4] update ci to 3.41 --- .github/workflows/build-app.yml | 12 ++++++------ .github/workflows/flutter.yml | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build-app.yml b/.github/workflows/build-app.yml index 9603939..0f268be 100644 --- a/.github/workflows/build-app.yml +++ b/.github/workflows/build-app.yml @@ -2,9 +2,9 @@ name: Build Test App on: push: - branches: [ "main" ] + branches: ["main"] pull_request: - branches: [ "main" ] + branches: ["main"] permissions: contents: read @@ -33,13 +33,13 @@ jobs: cpu: pi4 steps: - uses: actions/checkout@v4 - + - uses: subosito/flutter-action@v2 with: cache: true channel: stable - flutter-version: 3.38.4 - + flutter-version: 3.41.0 + - name: Install dependencies & Activate as global executable run: | flutter pub get @@ -60,7 +60,7 @@ jobs: echo '::group::flutterpi_tool build ... --debug' flutterpi_tool build --arch=${{ matrix.arch }} --cpu=${{ matrix.cpu }} --debug --debug-symbols --verbose echo '::endgroup::' - + echo '::group::flutterpi_tool build ... --profile' flutterpi_tool build --arch=${{ matrix.arch }} --cpu=${{ matrix.cpu }} --profile --debug-symbols --verbose echo '::endgroup::' diff --git a/.github/workflows/flutter.yml b/.github/workflows/flutter.yml index cabccc1..d9779b5 100644 --- a/.github/workflows/flutter.yml +++ b/.github/workflows/flutter.yml @@ -7,9 +7,9 @@ name: Flutter on: push: - branches: [ "main" ] + branches: ["main"] pull_request: - branches: [ "main" ] + branches: ["main"] permissions: contents: read @@ -21,16 +21,16 @@ jobs: GITHUB_TOKEN: ${{ secrets.TOKEN }} steps: - uses: actions/checkout@v4 - + - uses: subosito/flutter-action@v2 with: cache: true channel: stable - flutter-version: 3.38.4 - + flutter-version: 3.41.0 + - name: Install dependencies run: flutter pub get - + - name: Verify formatting run: dart format --output=none --set-exit-if-changed . From 22efddb500c418a90f041bb7c4a5985aa00c7b0b Mon Sep 17 00:00:00 2001 From: mcz Date: Sat, 21 Feb 2026 13:31:20 +0100 Subject: [PATCH 2/4] Fix pollingGetDevices signature to match Flutter 3.41.x Add missing `forWirelessDiscovery` named parameter to `FlutterpiSshDeviceDiscovery.pollingGetDevices` to match the updated `PollingDeviceDiscovery` base class in Flutter >= 3.41.1. Fixes #87 --- lib/src/devices/flutterpi_ssh/device_discovery.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/devices/flutterpi_ssh/device_discovery.dart b/lib/src/devices/flutterpi_ssh/device_discovery.dart index 1fd78f7..b01e7b2 100644 --- a/lib/src/devices/flutterpi_ssh/device_discovery.dart +++ b/lib/src/devices/flutterpi_ssh/device_discovery.dart @@ -53,7 +53,7 @@ class FlutterpiSshDeviceDiscovery extends PollingDeviceDiscovery { } @override - Future> pollingGetDevices({Duration? timeout}) async { + Future> pollingGetDevices({Duration? timeout, bool forWirelessDiscovery = false}) async { timeout ??= Duration(seconds: 5); final entries = config.getDevices(); From db0c160e50f2501e418cdbd4507a41420af9fbf7 Mon Sep 17 00:00:00 2001 From: Hannes Winkler Date: Mon, 6 Apr 2026 13:43:44 +0200 Subject: [PATCH 3/4] `dart format`, add trailing comma --- lib/src/devices/flutterpi_ssh/device_discovery.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/src/devices/flutterpi_ssh/device_discovery.dart b/lib/src/devices/flutterpi_ssh/device_discovery.dart index b01e7b2..c442beb 100644 --- a/lib/src/devices/flutterpi_ssh/device_discovery.dart +++ b/lib/src/devices/flutterpi_ssh/device_discovery.dart @@ -53,7 +53,10 @@ class FlutterpiSshDeviceDiscovery extends PollingDeviceDiscovery { } @override - Future> pollingGetDevices({Duration? timeout, bool forWirelessDiscovery = false}) async { + Future> pollingGetDevices({ + Duration? timeout, + bool forWirelessDiscovery = false, + }) async { timeout ??= Duration(seconds: 5); final entries = config.getDevices(); From 2405b6afd6e1f42d5f26117e558fd705003f4d2e Mon Sep 17 00:00:00 2001 From: Hannes Winkler Date: Mon, 6 Apr 2026 13:50:51 +0200 Subject: [PATCH 4/4] fix tests add stub implementation stopExtendedWirelessDeviceDiscoverers in FakeDeviceManager --- test/src/fake_device_manager.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/src/fake_device_manager.dart b/test/src/fake_device_manager.dart index 8dd7172..c675b15 100644 --- a/test/src/fake_device_manager.dart +++ b/test/src/fake_device_manager.dart @@ -94,6 +94,9 @@ class FakeDeviceManager implements fl.DeviceManager { @override fl.Device? getSingleEphemeralDevice(List devices) => null; + + @override + void stopExtendedWirelessDeviceDiscoverers() {} } class FakeFilter extends Fake implements fl.DeviceDiscoverySupportFilter {