Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/api-client/src/fetch.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,34 @@ describe("apiFetch", () => {
expect(fetchMock).toHaveBeenCalledTimes(2);
});

it("adds stable request id and increments retry attempt headers", async () => {
const requestIds: string[] = [];
const retryAttempts: string[] = [];
const fetchMock = vi.fn(async (input: RequestInfo | URL) => {
const request = input instanceof Request ? input : new Request(input);
requestIds.push(request.headers.get("x-argos-request-id") ?? "");
retryAttempts.push(request.headers.get("x-argos-retry-attempt") ?? "");

return new Response("{}", {
status: requestIds.length === 1 ? 500 : 200,
});
});

const response = await apiFetch(
new Request("https://api.argos-ci.test/builds"),
{
fetch: fetchMock as unknown as typeof fetch,
minTimeout: 0,
},
);

expect(response.status).toBe(200);
expect(requestIds).toHaveLength(2);
expect(requestIds[0]).toBeTruthy();
expect(requestIds[0]).toBe(requestIds[1]);
expect(retryAttempts).toEqual(["0", "1"]);
});

it("aborts the request after the configured timeout", async () => {
const fetchMock = vi.fn(
async (input: RequestInfo | URL) =>
Expand Down
17 changes: 12 additions & 5 deletions packages/api-client/src/fetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,19 @@ async function createRequestFactory(request: Request, timeout: number) {
// Snapshot the body once so retries do not clone/tee the original Request.
const body = request.body ? await request.arrayBuffer() : undefined;
const headers = new Headers(request.headers);
const existingRequestId = headers.get("x-argos-request-id")?.trim();
const requestId = existingRequestId || globalThis.crypto.randomUUID();

return () =>
new Request(request.url, {
return (retryAttempt: number) => {
const requestHeaders = new Headers(headers);
requestHeaders.set("x-argos-request-id", requestId);
requestHeaders.set("x-argos-retry-attempt", String(retryAttempt));

return new Request(request.url, {
body,
cache: request.cache,
credentials: request.credentials,
headers,
headers: requestHeaders,
integrity: request.integrity,
keepalive: request.keepalive,
method: request.method,
Expand All @@ -36,6 +42,7 @@ async function createRequestFactory(request: Request, timeout: number) {
referrerPolicy: request.referrerPolicy,
signal: AbortSignal.any([request.signal, AbortSignal.timeout(timeout)]),
});
};
}

export async function apiFetch(input: Request, options: APIFetchOptions = {}) {
Expand All @@ -48,8 +55,8 @@ export async function apiFetch(input: Request, options: APIFetchOptions = {}) {
);

return pRetry(
async () => {
const response = await fetchImpl(createRequest());
async (attemptNumber) => {
const response = await fetchImpl(createRequest(attemptNumber - 1));
if (response.status >= 500) {
throw new APIError(`Internal Server Error (${response.status})`);
}
Expand Down
Loading