Add name to from address

[tehsu]

Is there anyway to get the name added to the from address, for instance we have one list but send from two different emails to the one list. This distinguishes what the email is for to our readers. So when I sent the email right now it shows just the email, can it capture the name of that email address?

[arnoldle]

You’d like the From: address of the person who submits the message to carry through and appear in the message sent to the subscribers? Is that right?

Arnold

On Jun 16, 2015, at 12:24 PM, tehsu notifications@github.com wrote:

Is there anyway to get the name added to the from address, for instance we have one list but send from two different emails to the one list. This distinguishes what the email is for to our readers. So when I sent the email right now it shows just the email, can it capture the name of that email address?

—
Reply to this email directly or view it on GitHub #3.

[tehsu]

Yeah, so, instead of From: news@snyde.net, I would like From: News news@snyde.net. I'm looking through the code, maybe I can get it myself, but any help is appreciated.

[arnoldle]

Hi,

I don’t think that this is something you can do with my plugin; phpList sets how that address looks.

There is really nothing I can do for you here with the plugin code.

Sorry,
Arnold

On Jun 16, 2015, at 1:30 PM, tehsu notifications@github.com wrote:

Yeah, so, instead of From: news@snyde.net mailto:news@snyde.net, I would like From: News news@snyde.net mailto:news@snyde.net. I'm looking through the code, maybe I can get it myself, but any help is appreciated.

—
Reply to this email directly or view it on GitHub #3 (comment).

[tehsu]

If I send an email from phpList, I can add the name to the from address. For instance, the from line in a campaign has news@snyde.net Snyde News. Is it not possible to add the name of the sender to the from address?

[arnoldle]

You do that by hand, in the editor, right?

A.

On Jun 16, 2015, at 1:39 PM, tehsu notifications@github.com wrote:

If I send an email from phpList, I can add the name to the from address. For instance, the from line in a campaign has news@snyde.net mailto:news@snyde.net Snyde News. Is it not possible to add the name of the sender to the from address?

—
Reply to this email directly or view it on GitHub #3 (comment).

[tehsu]

Yeah, I add it as pictured.

[arnoldle]

As it stands now, the plugin puts the email address of the submitter in the From: line, not the a list address. With phpList, the From: line would normally be the list owner. However, that can be changed in the editor, as you know.

One problem here is that "news@snyde.net mailto:news@snyde.net Snyde News” is not a proper email address. It ought to be Snyde News<news@snyde.net mailto:news@snyde.net>.” So there is no way that the plugin could do the first address. It could probably include a display name in the correct form with some code modifications. But you would need to create a email account news@snyde.net mailto:news@snyde.net with “Snyde News” as the display name. You would need to submit messages to the list from that account.

I don’t see how I could provide an arbitrary From address.

A.

On Jun 16, 2015, at 1:39 PM, tehsu notifications@github.com wrote:

If I send an email from phpList, I can add the name to the from address. For instance, the from line in a campaign has news@snyde.net mailto:news@snyde.net Snyde News. Is it not possible to add the name of the sender to the from address?

—
Reply to this email directly or view it on GitHub #3 (comment).

[tehsu]

The emails we are using do have the display names set as you've said. Also, the from line can be set as "Snyde News news@snyde.net". I see that the code below strips out the email, does this also send the stripped email to the From: line? All I need is, instead of stripping it to just the email, I would use a regex to keep the name and pass that along to the from line.

    function cleanAdr ($adr) {
            if (preg_match('/<(.*)>/', $adr, $match))
                    return trim($match[1]);
            return trim();
    }

[arnoldle]

I was just looking at that. I think that what we need to do is to define another property: $displayName.

We set it in the cleanAdr function including setting it to an empty string, if there is no display name in the sender’s address.

Then in the function loadMessageData, we change the line

$messagedata['fromfield'] = $this->sender;

to insert the $this->displayName, if it is there.

So here are the changes as I see them:

At line 172: below
public $sender;
Add
public $displayName;
(I’m not sure at the moment that these have to be public. Best leave them public for now.)

Then at line 483 change function cleanAdr() as follows:

function cleanAdr ($adr) { 
    $this->displayName = '’; 
     if (preg_match('/<(.*)>/', $adr, $match)) { 
         $this->displayName = trim(str_replace($match[0],'', $adr)); 
         return trim($match[1]); 
    } 
    return trim($adr); 
}

The in the function loadMessageData() the line $messagedata['fromfield'] = $this->sender; becomes

$messagedata['fromfield'] = ($this->displayName? $this->displayName . ‘<‘ . $this->sender . ‘>’ : $this->sender);

The parentheses are not syntactically necessary, but may make the meaning of the line clearer.

Can you try this out and inform me of the result? If everything works OK, I will make the change in the repository.

A.

On Jun 16, 2015, at 2:13 PM, tehsu notifications@github.com wrote:

The emails we are using do have the display names set as you've said. Also, the from line can be set as "Snyde News news@snyde.net mailto:news@snyde.net". I see that the code below strips out the email, does this also send the stripped email to the From: line? All I need is, instead of stripping it to just the email, I would use a regex to keep the name and pass that along to the from line.

function cleanAdr ($adr) {
        if (preg_match('/<(.*)>/', $adr, $match))
                return trim($match[1]);
        return trim();
}

—
Reply to this email directly or view it on GitHub #3 (comment).

[tehsu]

So, now its getting the name of my list@snyde.net which is Snyde List as the from address.

[arnoldle]

I don' t understand. Did you make the changes I suggested? Is the display name of the sender not being shown?

Sent from my iPad

On Jun 16, 2015, at 3:09 PM, tehsu notifications@github.com wrote:

So, now its getting the name of my list@snyde.net which is Snyde List as the from address.

—
Reply to this email directly or view it on GitHub.

[tehsu]

Yes, I made the changes. So I send an email from "Community News community@snyde.net" to "Snyde List list@snyde.net" the list@snyde.net address is where the email is collected using this plugin. Now when I receive the email, it is from "Snyde mailto:Listcommunity@snyde.net" when I check the from on the sent campaign in phplist, it says "Snyde List"

Instead of "Community News" Snyde is being set as the name of the user and list is being prefixed to the actual email address.

[tehsu]

Ok, so I fixed where List becomes part of the domain, it just pulling the name of the collection email instead of the sending email

[arnoldle]

OK. So there is something else going on that we don’t understand yet. I will take a look at it and get back to you.

A.

On Jun 16, 2015, at 3:17 PM, tehsu notifications@github.com wrote:

Yes, I made the changes. So I send an email from "Community News community@snyde.net mailto:community@snyde.net" to "Snyde List list@snyde.net mailto:list@snyde.net" the list@snyde.net mailto:list@snyde.net address is where the email is collected using this plugin. Now when I receive the email, it is from "Snyde Listcommunity@snyde.net mailto:Listcommunity@snyde.net" when I check the from on the sent campaign in phplist, it says "Snyde List"

—
Reply to this email directly or view it on GitHub #3 (comment).

[arnoldle]

Where is that?

On Jun 16, 2015, at 3:33 PM, tehsu notifications@github.com wrote:

Ok, so I fixed where List becomes part of the domain, it just pulling the name of the collection email instead of the sending email

—
Reply to this email directly or view it on GitHub #3 (comment).