Disposable: use two independent comparisons in isDisposable

aminya · aminya · commit 6defe8e50ba9 · 2020-10-24T01:07:44.000-05:00
diff --git a/lib/disposable.js b/lib/disposable.js
@@ -8,7 +8,7 @@ export default class Disposable {
   //
   // Returns a {Boolean} indicating whether `object` is a valid `Disposable`.
   static isDisposable(object) {
-    return typeof (object != null ? object.dispose : undefined) === "function"
+    return Boolean(object) && (typeof object.dispose === "function")
   }
 
   /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export default class Disposable {`
`8`	`8`	`//`
`9`	`9`	// Returns a {Boolean} indicating whether `object` is a valid `Disposable`.
`10`	`10`	`static isDisposable(object) {`
`11`		`- return typeof (object != null ? object.dispose : undefined) === "function"`
	`11`	`+ return Boolean(object) && (typeof object.dispose === "function")`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`/*`