From 69504004dd80527cbfdb867475bc4608621a1a82 Mon Sep 17 00:00:00 2001 From: Adrian Torchiana Date: Mon, 25 Aug 2025 21:52:23 -0700 Subject: [PATCH 1/3] Blow up tests on purpose to make sure github action fails --- .github/workflows/actions.yml | 2 +- .../java/atorch/statspuzzles/PuzzleSelectionTest.java | 2 +- app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index 616781a..b48a28b 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG'] + locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG', 'fr-FR'] steps: - name: checkout uses: actions/checkout@v4 diff --git a/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java b/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java index 785f739..171803d 100644 --- a/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java +++ b/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java @@ -30,7 +30,7 @@ public void mainActivityLoads() { @Test public void easyPuzzlesButton_loadsEasyPuzzles() { Context context = InstrumentationRegistry.getInstrumentation().getTargetContext(); - Espresso.onView(ViewMatchers.withText(context.getString(R.string.button_level_0))).perform(click()); + Espresso.onView(ViewMatchers.withText(context.getString(R.string.button_level_5))).perform(click()); Espresso.onView(ViewMatchers.withText(context.getString(R.string.puzzle, 1))) .check(ViewAssertions.matches(ViewMatchers.isDisplayed())); } diff --git a/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java b/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java index 8febe86..0165cd2 100644 --- a/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java +++ b/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java @@ -13,6 +13,7 @@ public void testCorrectAnswer() { // Note that we have a Result.INACCURATE version of this test as well assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("1/3", "0.33333333333333")); assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("C(5, 3)", "10")); + assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("e*pi", "3.56")); } @Test From b4a2613e2054d2aaa027429bbec331fc245d8a32 Mon Sep 17 00:00:00 2001 From: Adrian Torchiana Date: Mon, 25 Aug 2025 21:55:53 -0700 Subject: [PATCH 2/3] Fix testCorrectAnswer to make sure the other steps fail --- app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java b/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java index 0165cd2..97c0b7e 100644 --- a/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java +++ b/app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java @@ -13,7 +13,7 @@ public void testCorrectAnswer() { // Note that we have a Result.INACCURATE version of this test as well assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("1/3", "0.33333333333333")); assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("C(5, 3)", "10")); - assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("e*pi", "3.56")); + assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("1/(3!)", "0.16666666")); } @Test From b3f71b508cda91369dd721c11de788b8766b58d2 Mon Sep 17 00:00:00 2001 From: Adrian Torchiana Date: Mon, 25 Aug 2025 22:11:51 -0700 Subject: [PATCH 3/3] Update app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java Undo one deliberate test failure Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../java/atorch/statspuzzles/PuzzleSelectionTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java b/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java index 171803d..785f739 100644 --- a/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java +++ b/app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTest.java @@ -30,7 +30,7 @@ public void mainActivityLoads() { @Test public void easyPuzzlesButton_loadsEasyPuzzles() { Context context = InstrumentationRegistry.getInstrumentation().getTargetContext(); - Espresso.onView(ViewMatchers.withText(context.getString(R.string.button_level_5))).perform(click()); + Espresso.onView(ViewMatchers.withText(context.getString(R.string.button_level_0))).perform(click()); Espresso.onView(ViewMatchers.withText(context.getString(R.string.puzzle, 1))) .check(ViewAssertions.matches(ViewMatchers.isDisplayed())); }