-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
Description
- The "searchspace_str" has to be removed from the initializer of
BaseProfile. It's unintuitive. - The file name
profile_config.pyis also confusing and needs to be updated. - Method
configure_extrahas a different signature compared to the otherconfigure_methods. get_name_wandb_run-> improve the name. The emphasis should be on the experiment name, not the "wandb name". Perhaps it's better to move this method elsewhere (having it here is what raises the need for searchspace_str in the init). The Experiment class seems like a suitable candidate.- The configs in
_initialize_train_config_xyzare better of as config (yaml?) files which are included with the library, which are read and loaded into theBaseProfileclass. set_searchspace_configshould has the same function but asconfigure_xyzbut a different naming convention. Rename it.
Reactions are currently unavailable