Simplex Sending out Unnecessary Replication Requests

[samliok]

Our current replication logic keeps track of a highestSequenceObserved. This gets initially set when we receive a finalization from a future round, but can be updated during the replication process if a node sends us a LatestRound with a higher sequence.

Setting LatestRound see here
Updating highestSequenceObserved with LatestRound see here

We assume highestSequenceObserved keep tracks of the latest Finalized sequence and will therefore re-send replication requests until we get a finalization for that sequence. However, it's possible that we have actually caught up since the LatestRound sent prior was a notarization.

[samliok]

this gets tricky though, since we may have initially received a finalization for seq say 10, but other nodes have already finalizaed seq 15 and have notarizations up to seq 20. So when they respond with a LatestRound of seq 20 we do not know when the notarizations/ & finalization start/end. Maybe the LatestRound should be split into LatestFinalizedRound and LatestNotarizedRound

[yacovm]

I think we should just mark whether the latest round is a finalization or a notarization and then if you have replicated a notarization of that round but not the finalization you simply won't retry.

[samliok]

I think we should just mark whether the latest round is a finalization or a notarization and then if you have replicated a notarization of that round but not the finalization you simply won't retry.

saw we are at seq 10 and get a future finalization of seq 20. then right after we get a notarization of 21 we wont resend requests for sequences 10-20

[yacovm]

I think we should just mark whether the latest round is a finalization or a notarization and then if you have replicated a notarization of that round but not the finalization you simply won't retry.

saw we are at seq 10 and get a future finalization of seq 20. then right after we get a notarization of 21 we wont resend requests for sequences 10-20

why?