Add EPV, unit, functional, smoke, and integration tests

[avandenberghe]

Summary

Add a comprehensive test suite for the bbGuild WoW plugin covering all test levels required for phpBB extension validation.

Test levels

EPV (Extension Pre-Validator)

• Ensure the extension passes phpbb/epv checks (composer.json, file structure, coding standards)
• Add phpbb/epv to require-dev
• CI workflow to run EPV on every push

Unit tests

• wow_api.php — to_slug(), error_label(), process logic (mock API responses)
• wow_provider.php — get_armor_types(), get_regions(), get_api_locales()
• wow_installer.php — verify class/race/faction seed data arrays

Functional tests

• battlenet_character.php — test endpoint URL construction for all methods (getCharacter, getCharacterMedia, getCharacterEquipment, getCharacterStatistics, getCharacterProfessions, getCharacterMythicKeystoneProfile, getCharacterPvPSummary, getCharacterSpecializations)
• battlenet_resource.php — OAuth token caching, 401 retry, namespace header construction
• sync_portraits(), sync_specs(), sync_equipment() — test with mock DB and mock API responses

Smoke tests

• Extension enables without errors
• Extension disables and re-enables without data loss
• ACP guild edit page loads with WoW guild (no PHP warnings)
• Player detail page loads for a WoW character

Integration tests

• Full guild sync flow: roster → specs → portraits → equipment
• Player detail event listener: verify all template vars are assigned
• Achievement browser: category list → achievement list → detail

Test infrastructure

• phpBB test framework (phpbb/test-framework)
• PHPUnit configuration (phpunit.xml.dist)
• GitHub Actions CI workflow
• Test fixtures for mock API responses

Reference

• phpBB testing docs: https://area51.phpbb.com/docs/dev/master/testing/
• bbguild core test issue: Add unit tests bbguild#244

[avandenberghe]

Progress update — 2026-04-26

Done

• EPV: passing on every push. CI configured in .github/workflows/tests.yml → basic-checks job (uses phpbb-extensions/test-framework). All previous fatals fixed:
  • Event docblocks updated with @since (commits 5fc520a3, 6692958a in bbguild core)
  • Underscore-in-composer-name resolved by dropping the separator everywhere (bbguildwow)
  • Unserialize calls in core's log model replaced with JSON
• Unit tests: passing on every push across PHP 8.1–8.4 against postgres. Workflow checks out bbguild core alongside bbguildwow so plugin classes can resolve core's interfaces (commit f9a96af). Existing tests:
  • tests/system/ext_test.php
  • tests/api/battlenet_resource_test.php, battlenet_character_test.php
  • tests/game/wow_api_test.php, wow_installer_test.php, wow_provider_test.php

Documented (not yet implemented)

Five planning docs added in tests/:

File	Tests proposed
tests/epv-tests.md	rule reference (no test files to write)
tests/unit-tests.md	7 suggested additions on top of 6 existing
tests/functional-tests.md	8 functional tests covering enable, game registry, guild render, player detail, ACP Battle.net config, sync route authz, achievement browser, disable-keeps-core
tests/smoke-tests.md	5 minimum-viable "lights on" checks
tests/integration-tests.md	6 sync/cache paths (OAuth, roster, equipment, achievement, aggregation, cache invalidation)

Outstanding

• Implement functional tests (currently excluded in CI via --exclude-group functional)
• Implement smoke tests
• Implement integration tests
• Implement the 7 suggested unit test additions

Status remains In Progress on the @avatharbe kanban.