Modal state is not inactive after modal is closed

[akrawchyk]

The undelegateModalEvents function is not called when a modal is canceled or closed for another reason. It looks as though the modal checks if we have a viewContainer, here

backbone.modal/src/backbone.modal.coffee

Line 249 in daed180

if @regionEnabled

and here

backbone.modal/src/backbone.modal.coffee

Line 260 in daed180

if @regionEnabled

, except @regionEnabled does not seem to be set anywhere else in the code. That means destroy will always be called on a successful triggerCancel and triggerSubmit.

So, I think we should call undelegateModalEvents every time destroy is called in order to always remove events from the inactive modal and return the modal state back to inactive (@active = false called only in the undelegateModelEvents function here

backbone.modal/src/backbone.modal.coffee

Line 119 in daed180

@active = false

).

[akrawchyk]

BTW there is an easy workaround for this. When extending the modal, simply call undelegateModalEvents in the onDestroy function:

var Modal = Backbone.Modal.extend({
    ...
    onDestroy: {
        this.undelegateModalEvents();
    },
    ...
});