Skip to content

Commit e431d8c

Browse files
committed
fix(deploy): resolve online-eval step on re-deploys with no new configs
The TUI deploy screen renders an "Enable online evaluation" step whenever projectSpec.onlineEvalConfigs is non-empty, but the step was only transitioned to a terminal status inside the `if (newOnlineEvalFullSpecs > 0 ...)` branch. On a re-deploy where every configured online eval was already deployed in a prior run, that branch is skipped and the step stays in 'pending', so areStepsComplete() never returns true and the deploy phase never reaches 'complete' — the TUI hangs after the AWS deploy itself succeeds. Mirror the dataset-sync block above by marking the step success when there are configs but nothing new to enable.
1 parent 9fdab06 commit e431d8c

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

src/cli/tui/screens/deploy/useDeployFlow.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,10 @@ export function useDeployFlow(options: DeployFlowOptions = {}): DeployFlowState
656656
logger.endStep('error', message);
657657
setOnlineEvalStep(prev => ({ ...prev, status: 'error', error: message }));
658658
}
659+
} else if (onlineEvalFullSpecs.length > 0) {
660+
// Step is rendered whenever onlineEvalConfigs is non-empty, but only runs for newly
661+
// deployed configs. With nothing new to enable, mark it terminal so the deploy completes.
662+
setOnlineEvalStep(prev => ({ ...prev, status: 'success' }));
659663
}
660664

661665
// Config bundles are now managed via CloudFormation; their state is parsed

0 commit comments

Comments
 (0)