Update ApiGatewayRequestIdentity and AwsProxyRequestContext static factory methods with realistic defaults for issue #1495

Author: dgomesbr

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/model/ApiGatewayRequestIdentity.java

@@ -28,26 +28,26 @@
 public class ApiGatewayRequestIdentity {
 
     /**
-     * Creates an ApiGatewayRequestIdentity instance with default values.
+     * Creates an ApiGatewayRequestIdentity instance with default values based on a typical API Gateway request.
      * 
      * @return A pre-configured ApiGatewayRequestIdentity instance
      */
     public static ApiGatewayRequestIdentity getApiGatewayRequestIdentity() {
         ApiGatewayRequestIdentity identity = new ApiGatewayRequestIdentity();
-        // Set default values for all fields
-        identity.setApiKey("");
-        identity.setApiKeyId("");
-        identity.setUserArn("");
-        identity.setCognitoAuthenticationType("");
-        identity.setCaller("");
-        identity.setUserAgent("");
-        identity.setUser("");
-        identity.setCognitoIdentityPoolId("");
-        identity.setCognitoIdentityId("");
-        identity.setCognitoAuthenticationProvider("");
-        identity.setSourceIp("127.0.0.1"); // Reasonable default
-        identity.setAccountId("");
-        identity.setAccessKey("");
+        // Set default values based on example API Gateway request
+        identity.setApiKey(null);
+        identity.setApiKeyId(null);
+        identity.setUserArn(null);
+        identity.setCognitoAuthenticationType(null);
+        identity.setCaller(null);
+        identity.setUserAgent("Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36");
+        identity.setUser(null);
+        identity.setCognitoIdentityPoolId(null);
+        identity.setCognitoIdentityId(null);
+        identity.setCognitoAuthenticationProvider(null);
+        identity.setSourceIp("127.0.0.1");
+        identity.setAccountId(null);
+        identity.setAccessKey(null);
         return identity;
     }
 

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/model/AwsProxyRequestContext.java

@@ -29,27 +29,27 @@
 public class AwsProxyRequestContext {
 
     /**
-     * Creates an AwsProxyRequestContext instance with default values.
+     * Creates an AwsProxyRequestContext instance with default values based on a typical API Gateway request.
      * 
      * @return A pre-configured AwsProxyRequestContext instance
      */
     public static AwsProxyRequestContext getAwsProxyRequestContext() {
         AwsProxyRequestContext context = new AwsProxyRequestContext();
-        // Set default values for all fields
-        context.setResourceId("");
-        context.setApiId("");
-        context.setResourcePath("");
-        context.setHttpMethod("GET"); // Reasonable default
-        context.setRequestId("");
+        
+        // Set default values based on typical API Gateway request
+        context.setAccountId("123456789012");
+        context.setApiId("id");
+        context.setResourceId("$default");
+        context.setResourcePath("/my/path");
+        context.setHttpMethod("POST");
+        context.setRequestId("id");
         context.setExtendedRequestId("");
-        context.setAccountId("");
-        context.setStage("");
-        context.setPath("");
-        context.setProtocol("");
-        context.setRequestTime("");
+        context.setStage("$default");
+        context.setPath("/my/path");
+        context.setProtocol("HTTP/1.1");
         context.setRequestTimeEpoch(System.currentTimeMillis()); // Current time as reasonable default
 
-        // Create and set identity with defaults
+        // Create and set identity with defaults (already includes sourceIp and userAgent)
         context.setIdentity(ApiGatewayRequestIdentity.getApiGatewayRequestIdentity());
 
         // Initialize authorizer