Improve new line replace algo

Thibaud Fabre · Thibaud Fabre · commit 5d50e4c61eb1 · 2014-09-12T12:21:12.000+02:00
diff --git a/src/Aztech/Sniffs/Formatting/NoConsecutiveBlankLinesSniff.php b/src/Aztech/Sniffs/Formatting/NoConsecutiveBlankLinesSniff.php
@@ -32,10 +32,12 @@ public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
             $buffer .= str_replace(' ', '', $token['content']);
 
             if (strpos($buffer, PHP_EOL . PHP_EOL . PHP_EOL) !== false) {
-                $error = 'There should be no consecutive blank lines';
+                $error = 'There must be no consecutive blank lines';
                 $phpcsFile->addError($error, $ptr, 'ConsecutiveBlankLines');
 
-                $buffer = str_replace(PHP_EOL . PHP_EOL . PHP_EOL, PHP_EOL, $buffer);
+                while (strpos($buffer, PHP_EOL . PHP_EOL . PHP_EOL) !== false) {
+                    $buffer = str_replace(PHP_EOL . PHP_EOL . PHP_EOL, PHP_EOL . PHP_EOL, $buffer);
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,12 @@ public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)`
`32`	`32`	`$buffer .= str_replace(' ', '', $token['content']);`
`33`	`33`
`34`	`34`	`if (strpos($buffer, PHP_EOL . PHP_EOL . PHP_EOL) !== false) {`
`35`		`- $error = 'There should be no consecutive blank lines';`
	`35`	`+ $error = 'There must be no consecutive blank lines';`
`36`	`36`	`$phpcsFile->addError($error, $ptr, 'ConsecutiveBlankLines');`
`37`	`37`
`38`		`- $buffer = str_replace(PHP_EOL . PHP_EOL . PHP_EOL, PHP_EOL, $buffer);`
	`38`	`+ while (strpos($buffer, PHP_EOL . PHP_EOL . PHP_EOL) !== false) {`
	`39`	`+ $buffer = str_replace(PHP_EOL . PHP_EOL . PHP_EOL, PHP_EOL . PHP_EOL, $buffer);`
	`40`	`+ }`
`39`	`41`	`}`
`40`	`42`	`}`
`41`	`43`	`}`