From 04702680297afc0c91e5bbaa16c1291c0222a2ac Mon Sep 17 00:00:00 2001 From: Jacopo Scazzosi Date: Tue, 28 Apr 2026 17:42:05 +0200 Subject: [PATCH] fix: uses appropriate typings for property read/write request payloads This commit fixes a mistyping affecting read/write request payloads. For some reason, the payloads of events modelling read/write requests had been defined separately and independently of the payloads actually returned by the .decode() function of the service handler matching the incoming request. See src/lib/client.ts@530 for the parser invocation See src/lib/client.ts@557 for triggering of service request events --- src/lib/EventTypes.ts | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/lib/EventTypes.ts b/src/lib/EventTypes.ts index 2a9c6e57..0e283a5d 100644 --- a/src/lib/EventTypes.ts +++ b/src/lib/EventTypes.ts @@ -28,6 +28,8 @@ import { BACNetObjectID, BACNetPropertyID, BACNetAppData, + WritePropertyRequest, + ReadPropertyRequest, } from './types' export type Constructor = new (...args: any[]) => T @@ -74,22 +76,12 @@ export interface BaseEventContent { // These more specific interfaces help TypeScript provide better IntelliSense export interface ReadPropertyContent extends BaseEventContent { - payload: { - objectId: BACNetObjectID - property: BACNetPropertyID - } + payload: ReadPropertyRequest address?: string } export interface WritePropertyContent extends BaseEventContent { - payload: { - objectId: BACNetObjectID - property?: BACNetPropertyID - value?: { - property?: BACNetPropertyID - value?: BACNetAppData | BACNetAppData[] - } - } + payload: WritePropertyRequest } export interface ReadPropertyMultipleContent extends BaseEventContent {