Skip to content

Commit 80f06ce

Browse files
authored
Merge pull request #22 from bandoche/chore/cryptography-upgrade
Release 0.5.0
2 parents ed1609a + bf6050c commit 80f06ce

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

.circleci/config.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ version: 2.1
22

33

44
jobs:
5-
build-and-test-39: &template
5+
build-and-test-310: &template
66
docker:
7-
- image: circleci/python:3.9
7+
- image: circleci/python:3.10
88
steps:
99
- checkout
1010
- run:
@@ -25,6 +25,10 @@ jobs:
2525
- run:
2626
command: codecov
2727
name: Send coverage
28+
build-and-test-39:
29+
<<: *template
30+
docker:
31+
- image: circleci/python:3.9
2832
build-and-test-38:
2933
<<: *template
3034
docker:
@@ -40,6 +44,7 @@ jobs:
4044
workflows:
4145
main:
4246
jobs:
47+
- build-and-test-310
4348
- build-and-test-39
4449
- build-and-test-38
4550
- build-and-test-37

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ The current development version can be found at
6969

7070
## History
7171

72+
### Ver. 0.5.0 (2022-01-18)
73+
- Upgrade dependency (`cryptography==36.0.1`)
74+
- Fix file handle leakage
75+
7276
### Ver. 0.4.5 (2020-12-03)
7377
- Fix import path issue (thanks to [Gyong1211](https://github.com/Gyong1211))
7478

pypinksign/pypinksign.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ def _load_prikey_with_decrypted_data(self, decrypted_prikey_data: bytes) -> None
188188
def load_p12(self, p12_data: bytes = None) -> None:
189189
"""Load key information from P12(PKCS12, Usually pfx)"""
190190
if p12_data is None:
191-
p12_data = open(self.p12_path, 'rb').read()
191+
with open(self.p12_path, 'rb') as f:
192+
p12_data = f.read()
192193

193194
pubkey_data, prikey_data = separate_p12_into_npki(p12_data, self.prikey_password)
194195
self.load_pubkey(pubkey_data=pubkey_data)

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66

77
PROJECT = 'pypinksign'
8-
VERSION = '0.4.5'
8+
VERSION = '0.5.0'
99
URL = 'http://github.com/bandoche/PyPinkSign'
1010
AUTHOR = 'Sangjun Jung'
1111
AUTHOR_EMAIL = 'spamcoffee+pypinksign@gmail.com'
@@ -28,9 +28,9 @@
2828
zip_safe=False,
2929
install_requires=[
3030
'pyasn1==0.4.8',
31-
'cryptography==3.3.2',
31+
'cryptography==36.0.1',
3232
],
33-
keywords='npki 공인인증서 korean pki certificate',
33+
keywords='npki 공인인증서 공동인증서 korean pki certificate',
3434
platforms='OS Independent',
3535
classifiers=[
3636
'Development Status :: 4 - Beta',

0 commit comments

Comments
 (0)