From fec433db3cc9e52a72a0ca46c5204e10187a55fa Mon Sep 17 00:00:00 2001 From: Jeremy Daer Date: Mon, 27 Jul 2026 14:51:14 -0700 Subject: [PATCH] ci: bot PR authors are app/ in gh output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The full-cycle exercise in basecamp-sdk tripped the (correctly fail-closed) repair-PR re-verification: gh pr list reports the GITHUB_TOKEN-created PR's author as app/github-actions, not github-actions — the same app/ convention the old in-PR gate documented for app/dependabot. Auto-merge was refused and held runs left unapproved, exactly as designed; fix the constant in both checks. --- .github/workflows/dependabot-sync-actions-comments.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dependabot-sync-actions-comments.yml b/.github/workflows/dependabot-sync-actions-comments.yml index 7233809..e33d8c9 100644 --- a/.github/workflows/dependabot-sync-actions-comments.yml +++ b/.github/workflows/dependabot-sync-actions-comments.yml @@ -526,7 +526,8 @@ jobs: if [ "$count" = "1" ]; then author="$(jq -r '.[0].author.login' <<<"$prs")" base="$(jq -r '.[0].baseRefName' <<<"$prs")" - if [ "$author" != "github-actions" ] || [ "$base" != "$BASE_BRANCH" ]; then + # gh reports bot PR creators as app/ + if [ "$author" != "app/github-actions" ] || [ "$base" != "$BASE_BRANCH" ]; then echo "::error::existing ${REPAIR_BRANCH} PR is not the bot-owned repair PR (author=${author}, base=${base}); refusing to touch it" exit 1 fi @@ -585,7 +586,7 @@ jobs: base="$(jq -r '.[0].baseRefName' <<<"$prs")" author="$(jq -r '.[0].author.login' <<<"$prs")" num="$(jq -r '.[0].number' <<<"$prs")" - if [ "$oid" != "$NEW_HEAD" ] || [ "$base" != "$BASE_BRANCH" ] || [ "$author" != "github-actions" ]; then + if [ "$oid" != "$NEW_HEAD" ] || [ "$base" != "$BASE_BRANCH" ] || [ "$author" != "app/github-actions" ]; then echo "::error::repair PR does not match the proven commit (head=${oid}, base=${base}, author=${author}); not arming auto-merge" exit 1 fi