Merge pull request #15 from HaiTo/work/upgrade-for-php84

patch from kamilwylegala#83

Author: basi

.github/workflows/phpcs.yml

@@ -59,6 +59,11 @@ It means that composer will look at `master` branch of repository configured und
 
 ## Changelog
 
+### 2025-02-04
+
+- Fixes for PHP 8.4: `session_set_save_handler` accepts object, removed `E_STRICT` reference.
+- Removed github action with php code sniffer. It's quite painful to work with. Need to migrate to something newer, that will affect code base as little as possible.
+
 ### 2024-11-16
 
 - Inflector fix: str_place with null.

README.md

@@ -302,10 +302,6 @@ public static function mapErrorCode($code) {
 				$error = 'Notice';
 				$log = LOG_NOTICE;
 				break;
-			case E_STRICT:
-				$error = 'Strict';
-				$log = LOG_NOTICE;
-				break;
 			case E_DEPRECATED:
 			case E_USER_DEPRECATED:
 				$error = 'Deprecated';

lib/Cake/Error/ErrorHandler.php

@@ -23,6 +23,8 @@
 
 App::uses('Hash', 'Utility');
 App::uses('Security', 'Utility');
+App::uses('SessionHandlerAdapter', 'Model/Datasource');
+
 
 /**
  * Session class for CakePHP.
@@ -591,12 +593,7 @@ protected static function _configureSession() {
 			$handler = static::_getHandler($sessionConfig['handler']['engine']);
 			if (!function_exists('session_status') || session_status() !== PHP_SESSION_ACTIVE) {
 				session_set_save_handler(
-					array($handler, 'open'),
-					array($handler, 'close'),
-					array($handler, 'read'),
-					array($handler, 'write'),
-					array($handler, 'destroy'),
-					array($handler, 'gc')
+					new SessionHandlerAdapter($handler)
 				);
 			}
 		}

lib/Cake/Model/Datasource/CakeSession.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+class SessionHandlerAdapter implements SessionHandlerInterface
+{
+
+	public function __construct(
+		private CakeSessionHandlerInterface $cakeSessionHandler
+	) {
+	}
+
+	public function close()
+	{
+		return $this->cakeSessionHandler->close();
+	}
+
+	public function destroy(string $id)
+	{
+		return $this->cakeSessionHandler->destroy($id);
+	}
+
+	public function gc(int $max_lifetime)
+	{
+		return $this->cakeSessionHandler->gc($max_lifetime);
+	}
+
+	public function open(string $path, string $name)
+	{
+		//Cake interface ignores these parameters.
+		return $this->cakeSessionHandler->open();
+	}
+
+	public function read(string $id)
+	{
+		return $this->cakeSessionHandler->read($id);
+	}
+
+	public function write(string $id, string $data)
+	{
+		return $this->cakeSessionHandler->write($id, $data);
+	}
+}