fix(authn): run credential helper from the workspace root#896
Open
ashi009 wants to merge 1 commit into
Open
Conversation
Without `working_directory`, the credential helper subprocess inherits whatever CWD Bazel picks (typically an internal output-base path). Any helper that reads workspace-relative config — `.aws/config`, project-local credential files, custom helpers that resolve paths off the workspace root — currently fails to find them. Fixes bazel-contrib#895.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credential helper subprocess invoked by
oci_pullcurrently inherits whatever working directory Bazel picks (typically an internal output-base path), so helpers that read workspace-relative config (.aws/config, project-local credential files, custom helpers that resolve paths off the workspace root) fail to find them.This passes
working_directory = str(rctx.workspace_root)torctx.executeso the helper runs from the workspace root.Fixes #895.